1691213 - Some cleanup in native menu code, round 1

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, task, P5)

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1691213 - DeCOMtaminate nsINativeMenuService and rename it to mozilla::widget::NativeMenuSupport. r=spohl

Comment 2

[Markus Stange [:mstange]]

Attachment: Bug 1691213 - Remove unused method nsMenuBarX::GetLocalizedAccelKey. r=spohl

Depends on D104311

Comment 3

[Markus Stange [:mstange]]

Attachment: Bug 1691213 - Share mostly-duplicated function NativeMenuItemWithLocation. r=spohl

The only behavior difference (skipping the app menu) is now a boolean parameter.

Depends on D104312

Comment 4

[Markus Stange [:mstange]]

Attachment: Bug 1691213 - Add missing dom:: namespace annotations in nsMenuItemX.mm. r=spohl

Depends on D104313

Comment 5

[Markus Stange [:mstange]]

Attachment: Bug 1691213 - Add missing braces in cocoa menu code. r=spohl

ignore-this-changeset

This patch was automatically generated by running
~/.mozbuild/clang-tools/clang-tidy/bin/clang-tidy widget/cocoa/nsMenu*.mm widget/cocoa/nsStandaloneNativeMenu.mm -fix -checks="readability-braces-around-statements" -p /Users/mstange/code/obj-m-opt/clangd/

Depends on D104314

Comment 6

[Markus Stange [:mstange]]

Attachment: Bug 1691213 - Apply 'readability-else-after-return' and 'modernize-use-nullptr' clang-tidy fixes to native menu code. r=spohl

This patch was generated automatically, using the command
~/.mozbuild/clang-tools/clang-tidy/bin/clang-tidy widget/cocoa/nsMenu*.mm widget/cocoa/nsStandaloneNativeMenu.mm -fix -checks="readability-else-after-return,modernize-use-nullptr" -p /Users/mstange/code/obj-m-opt/clangd/

(and running it repeatedly until the entire if/return/else chain in nsMenuBarX.mm was handled)

Depends on D104315

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0cb9be29e060
DeCOMtaminate nsINativeMenuService and rename it to mozilla::widget::NativeMenuSupport. r=spohl
https://hg.mozilla.org/integration/autoland/rev/87c34a78967e
Remove unused method nsMenuBarX::GetLocalizedAccelKey. r=spohl
https://hg.mozilla.org/integration/autoland/rev/c4ee687e96d5
Share mostly-duplicated function NativeMenuItemWithLocation. r=spohl
https://hg.mozilla.org/integration/autoland/rev/a449e225c1d0
Add missing dom:: namespace annotations in nsMenuItemX.mm. r=spohl
https://hg.mozilla.org/integration/autoland/rev/6d5803bffccb
Add missing braces in cocoa menu code. r=spohl
https://hg.mozilla.org/integration/autoland/rev/1ff6cfdadceb
Apply 'readability-else-after-return' and 'modernize-use-nullptr' clang-tidy fixes to native menu code. r=spohl

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/0cb9be29e060
https://hg.mozilla.org/mozilla-central/rev/87c34a78967e
https://hg.mozilla.org/mozilla-central/rev/c4ee687e96d5
https://hg.mozilla.org/mozilla-central/rev/a449e225c1d0
https://hg.mozilla.org/mozilla-central/rev/6d5803bffccb
https://hg.mozilla.org/mozilla-central/rev/1ff6cfdadceb

Comment 9

[Olivier Tilloy]

All references to "@mozilla.org/widget/nativemenuservice;1" were removed in https://hg.mozilla.org/mozilla-central/rev/0cb9be29e060 except for one, in browser/base/content/browser-menubar.inc. This is probably an oversight?

Comment 10

[:Gijs (he/him)]

(In reply to Olivier Tilloy from comment #9)

All references to "@mozilla.org/widget/nativemenuservice;1" were removed in https://hg.mozilla.org/mozilla-central/rev/0cb9be29e060 except for one, in browser/base/content/browser-menubar.inc. This is probably an oversight?

Thanks for noticing. Looks like https://searchfox.org/mozilla-central/rev/3f97afc8db535f9b0232222cb48cc4cbf8334c76/widget/nsWidgetsCID.h#69-76 is also dead now. I filed bug 1695873.