Updating schema files for theme API
Categories
(Thunderbird :: Theme, enhancement)
Tracking
(thunderbird_esr78? fixed, thunderbird87 fixed)
People
(Reporter: TbSync, Assigned: TbSync)
Details
Attachments
(2 files, 2 obsolete files)
13.29 KB,
patch
|
Paenglab
:
review+
wsmwk
:
approval-comm-esr78+
|
Details | Diff | Splinter Review |
8.67 KB,
patch
|
Paenglab
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1684666 +++
After working on the API documentation for the new theme API, I found a few missing descriptions.
Assignee | ||
Comment 1•3 years ago
•
|
||
Only simple description changes. Includes a few changes from other APIs which did not bother me enough to create a bug yet.
Assignee | ||
Comment 2•3 years ago
|
||
Assignee | ||
Comment 3•3 years ago
|
||
Comment on attachment 9201627 [details] [diff] [review]
bug1691223_fix_schema_descriptions.patch
Only simple description changes.
Assignee | ||
Updated•3 years ago
|
Comment 4•3 years ago
|
||
Comment on attachment 9201621 [details] [diff] [review] bug1691223_fix_schema_descriptions_ESR78.patch Review of attachment 9201621 [details] [diff] [review]: ----------------------------------------------------------------- Thanks ::: mail/components/extensions/schemas/theme.json @@ +21,4 @@ > "choices": [ > { > + "type": "string", > + "description": "A string containing a valid `CSS color string <https://developer.mozilla.org/en-US/docs/Web/CSS/color_value#color_keywords>`__ or a hexadecimal representation. For example ``crimson`` or ``#dc143c``." Maybe you should also add rgb(a) and hsl(a) examples here.
Comment 5•3 years ago
|
||
Comment on attachment 9201627 [details] [diff] [review] bug1691223_fix_schema_descriptions.patch Review of attachment 9201627 [details] [diff] [review]: ----------------------------------------------------------------- Thanks. ::: mail/components/extensions/schemas/theme.json @@ +21,4 @@ > "choices": [ > { > + "type": "string", > + "description": "A string containing a valid `CSS color string <https://developer.mozilla.org/en-US/docs/Web/CSS/color_value#color_keywords>`__ or a hexadecimal representation. For example ``crimson`` or ``#dc143c``." Maybe you should also add rgb(a) and hsl(a) examples here.
Assignee | ||
Comment 6•3 years ago
|
||
Maybe you should also add rgb(a) and hsl(a) examples here.
Good catch, I did not know this works:
"theme": {
"colors": {
"exp_chat_button": "rgba(0,255,0,0.3)"
}
}
So I will update the description to be
"A string containing a valid CSS color string <https://developer.mozilla.org/en-US/docs/Web/CSS/color_value#color_keywords>
__, including hexadecimal or functional representation." And extend the examples. Would that be ok?
Comment 7•3 years ago
|
||
Sounds good.
Assignee | ||
Comment 8•3 years ago
|
||
Also update a few color definitions.
Assignee | ||
Comment 9•3 years ago
|
||
Also update a few color definitions.
You can see the rendered page and the added examples for rgba() and friends here:
https://webextension-api.thunderbird.net/en/78/theme.html#themecolor
Updated•3 years ago
|
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Comment 10•3 years ago
|
||
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/4f18ae7edfff
Update descriptions of theme API and others. r=Paenglab
Updated•3 years ago
|
Assignee | ||
Comment 11•3 years ago
|
||
Comment on attachment 9201764 [details] [diff] [review]
bug1691223_fix_schema_descriptions_ESR78_v2.patch
[Approval Request Comment]
Regression caused by (bug #):
User impact if declined:
Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky):
None, Description changes relevant for the API documentation only.
Comment 12•3 years ago
|
||
Comment on attachment 9201764 [details] [diff] [review]
bug1691223_fix_schema_descriptions_ESR78_v2.patch
[Triage Comment]
Approved for esr78
Comment 13•3 years ago
|
||
bugherder uplift |
Thunderbird 78.8.0:
https://hg.mozilla.org/releases/comm-esr78/rev/a9b796e8bf5c
Description
•