1691256 - Context Menu - can't make any selection (mouse-hover focus flickers on menu entries)

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[AllanB]

Attachment: Context Menu Bug.mov

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:85.0) Gecko/20100101 Firefox/85.0

Steps to reproduce:

Choose a bookmarks menu from the toolbar, right click on a bookmark in that menu to be able to delete the item from the context menu.

Actual results:

Can't choose any context menu items. Cursor flashes.

Expected results:

Cursor should highlight each item so the user can perform the selection. See the attached video.

This happens in Catalina on the Mac.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Bookmarks & History' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[AllanB]

In my opinion, this is a significant UI bug which has lingered for quite a while, and probably affects a lot of users. Managing bookmarks through the context menu is an integral part of the UI.

Comment 3

[Alice0775 White]

[Tracking Requested - why for this release]: It's an important UI issue. This seems to be a serious problem for some users.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Is this a regression?
And is this perhaps Mac only? (I can't reproduce on linux)

Comment 5

[Edgar Chen [:edgar]]

I could reproduce on Mac on 80, but not 74, I will try to find a regression window.

Comment 6

[Edgar Chen [:edgar]]

31:47.67 INFO: Last good revision: 9d2e5cd8c3c9c728d9d5e027fefd2fd3989b1880
31:47.67 INFO: First bad revision: 2c022fc5b638633885787aa94f1e46a7e6713956
31:47.67 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=9d2e5cd8c3c9c728d9d5e027fefd2fd3989b1880&tochange=2c022fc5b638633885787aa94f1e46a7e6713956

Comment 7

[Mirko Brodesser (:mbrodesser-Igalia)]

:emilio: as it's a regression of bug 1645773, do you mind having a closer look at it?

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1691256 - Specify background-color in OSX menus. r=mstange

Seems like triggering reflows on hover for these has undesired side effects
which I don't really have time to dig into right now, so for now restore the
behavior to the behavior before my patch.

Comment 9

[Emilio Cobos Álvarez (:emilio)]

That should do. Though maybe there's an slightly better fix which should deal with most other cases here, let me check...

Comment 10

[AllanB]

This happens on various Macs with Catalina and High Sierra.

Comment 11

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1691256 - Don't reflow for background/border changes on xul appearance values. r=jfkthame

This is an optimization, but also papers about XUL widgets not dealing
particularly well with it.

Comment 12

[Emilio Cobos Álvarez (:emilio)]

(In reply to AllanB from comment #10)

This happens on various Macs with Catalina and High Sierra.

Yeah, my fix should deal with all mac versions. But comment 11 is perhaps preferable too, since it should also make stuff faster in other cases.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa4c7f4629ff
Don't reflow for background/border changes on xul appearance values. r=jfkthame

Comment 14

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/aa4c7f4629ff

Comment 15

[Cristian Fogel [:cfogel]]

Confirmed issue with 82.0 on macOS 10.15/11.2.
Verified with atrif on 87.0 on macOS 10.15/11.2.