Closed
Bug 1691313
Opened 5 years ago
Closed 5 years ago
Rewrite `X.setAttribute("hidden", Y)` to `X.hidden = Y` in toolkit/
Categories
(Toolkit :: General, task, P2)
Toolkit
General
Tracking
()
RESOLVED
FIXED
87 Branch
| Tracking | Status | |
|---|---|---|
| firefox87 | --- | fixed |
People
(Reporter: ntim, Assigned: ntim)
References
Details
Attachments
(1 file)
+++ This bug was initially created as a clone of Bug #1691274 +++
(You should exclude the usages in toolkit/components/pdfjs which I'm taking care of in https://github.com/mozilla/pdf.js/pull/12971)
.setAttribute("hidden", "true"); -> .hidden = true;
.setAttribute("hidden", true); -> .hidden = true;
.setAttribute("hidden", "false"); -> .hidden = false;
.setAttribute("hidden", false); -> .hidden = false;
There's also an usage of .setAttribute("hidden", "");, I suspect that's just .hidden = true;, since those elements are HTML.
|
||
Updated•5 years ago
|
Severity: -- → N/A
Priority: -- → P2
|
Assignee | |
Comment 1•5 years ago
|
||
|
||
Updated•5 years ago
|
Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•5 years ago
|
Mentor: ntim.bugs
|
|
||
Updated•5 years ago
|
Attachment #9202477 -
Attachment description: Bug 1691313 - Use DOM hidden property instead of attribute methods in toolkit/. r=mtigley → Bug 1691313 - Use hidden DOM property instead of attribute methods in toolkit/. r=mtigley
|
|
Assignee | |
Updated•5 years ago
|
Keywords: good-first-bug
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/ab3b07242683
Use hidden DOM property instead of attribute methods in toolkit/. r=mtigley,preferences-reviewers,jaws
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox87:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•