Closed Bug 1691313 Opened 2 months ago Closed 2 months ago

Rewrite `X.setAttribute("hidden", Y)` to `X.hidden = Y` in toolkit/

Categories

(Toolkit :: General, task, P2)

task

Tracking

()

RESOLVED FIXED
87 Branch
Tracking Status
firefox87 --- fixed

People

(Reporter: ntim, Assigned: ntim)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1691274 +++

https://searchfox.org/mozilla-central/search?q=setAttribute%28%22hidden%22&path=toolkit%2F&case=false&regexp=false

(You should exclude the usages in toolkit/components/pdfjs which I'm taking care of in https://github.com/mozilla/pdf.js/pull/12971)

.setAttribute("hidden", "true"); -> .hidden = true;
.setAttribute("hidden", true); -> .hidden = true;

.setAttribute("hidden", "false"); -> .hidden = false;
.setAttribute("hidden", false); -> .hidden = false;

There's also an usage of .setAttribute("hidden", "");, I suspect that's just .hidden = true;, since those elements are HTML.

Blocks: 1691321
No longer blocks: 1592799
Severity: -- → N/A
Priority: -- → P2
Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED
Mentor: ntim.bugs
Attachment #9202477 - Attachment description: Bug 1691313 - Use DOM hidden property instead of attribute methods in toolkit/. r=mtigley → Bug 1691313 - Use hidden DOM property instead of attribute methods in toolkit/. r=mtigley
Keywords: good-first-bug
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/ab3b07242683
Use hidden DOM property instead of attribute methods in toolkit/. r=mtigley,preferences-reviewers,jaws
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in before you can comment on or make changes to this bug.