1691321 - Make XUL hidden attribute an HTML-style boolean attribute

Status: RESOLVED FIXED

(Core :: XUL, task)

Description

[Tim Nguyen :ntim]

See bug 1592799 comment 0

Comment 1

[Tim Nguyen :ntim]

Attachment: Bug 1691321 - Make XUL hidden attribute an HTML-style boolean attribute.

Comment 2

[Tim Nguyen :ntim]

Attachment: Bug 1691321 - Style changes to stop relying on XUL-style hidden attribute.

Depends on D104346

Comment 3

[Tim Nguyen :ntim]

I need to make a rewrite of hidden="true" to hidden="" or hidden="hidden" (I think I'll go with the former given this is the behaviour of the .hidden JS property).

https://searchfox.org/mozilla-central/search?q=hidden%3D%22true%22&path=&case=true&regexp=false (need to look out for attributes that aren't hidden but end with hidden)

Comment 4

[Tim Nguyen :ntim]

Summary of remaining work:

1. Figure out persisting hidden attribute removal (treecols rely on persisting hidden="false", which no-longer works in HTML land)
2. Rewriting hidden="true" in the codebase (not mandatory, but would be less confusing to do so)
3. Writing code in BrowserGlue.jsm to migrate: https://searchfox.org/mozilla-central/search?q=persist%3D%22.*hidden&path=&case=false&regexp=true
4. These 2 patches (they're pretty much done at time of writing, but might need updating later)

Comment 5

[Tim Nguyen :ntim]

Attachment: Bug 1691321 - Adjust XULPersist.cpp to work with boolean attributes better.

Depends on D104346

Comment 6

[Emilio Cobos Álvarez [:emilio]]

(In reply to Tim Nguyen :ntim from comment #4)

1. Figure out persisting hidden attribute removal (treecols rely on persisting hidden="false", which no-longer works in HTML land)

This works now bug 15232 is fixed.

Comment 7

[Mathew Hodson]

Done in bug 1979014