Open Bug 1691321 Opened 2 years ago Updated 3 months ago

Make XUL hidden attribute an HTML-style boolean attribute

Categories

(Core :: XUL, task)

task

Tracking

()

People

(Reporter: ntim, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

No longer depends on: 1604156
Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED
Assignee: ntim.bugs → nobody
Status: ASSIGNED → NEW
Depends on: 1692097
Depends on: 1692113

I need to make a rewrite of hidden="true" to hidden="" or hidden="hidden" (I think I'll go with the former given this is the behaviour of the .hidden JS property).

https://searchfox.org/mozilla-central/search?q=hidden%3D%22true%22&path=&case=true&regexp=false (need to look out for attributes that aren't hidden but end with hidden)

Depends on: 1692885

Summary of remaining work:

  1. Figure out persisting hidden attribute removal (treecols rely on persisting hidden="false", which no-longer works in HTML land)
  2. Rewriting hidden="true" in the codebase (not mandatory, but would be less confusing to do so)
  3. Writing code in BrowserGlue.jsm to migrate: https://searchfox.org/mozilla-central/search?q=persist%3D%22.*hidden&path=&case=false&regexp=true
  4. These 2 patches (they're pretty much done at time of writing, but might need updating later)
You need to log in before you can comment on or make changes to this bug.