1691349 - Screenshot node from the inspector on about:preferences makes the browser hang

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

Steps to reproduce

1. Navigate to about:preferences
2. Open the inspector
3. On the .main-content element, use the context menu entry to take a screenshot of the node

Actual results

The browser hangs for some reason

---

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'DevTools::Inspector' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1678483

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1691349 - [devtools] Fix screenshot node on about:preferences. r=bomsy.

The context menu action was freezing because of an infinite
loop in getRect: since we weren't passing a boundary window,
the function uses the top window, which can be the windowRoot.
But then, we walk up through the window using window.parent,
which would never get us the windowRoot, hence the infinite loop.
We fix this by providing the boundary window to getReact.
A test is added to ensure we don't regress in the future.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ed0dc85c25b
[devtools] Fix screenshot node on about:preferences. r=bomsy.

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/7ed0dc85c25b