1691446 - Implement Session for WebDriver BiDi

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

For the WebDriver BiDi implementation the Session handling will be identical to our WebDriver implementation (Marionette). As such the previously moved Session related files (bug 1691414) can now be used.

This bug covers the necessary implementation work to get the WebDriver Session support implemented. Hereby we have to make sure that the active session needs to be shared with Marionette, and both protocols operate on the same session data.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Note that in case of session creation through Marionette the BiDi implementation has to use the already existent session. But there are also cases when Marionette is not used and the websocket connection is made available by starting Firefox with the command line argument --remote-debugging-port. Hereby BiDi has to create the session.

Maybe it would be best to have the Session implemented as a singleton.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1691446 - [remote] Add support for handling WebDriverSession to WebDriver BiDi.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1691446 - [remote] Rename webdriverBiDi to webDriverBiDi.

Depends on D119730

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5bdb798c3b70
[remote] Add support for handling WebDriverSession to WebDriver BiDi. r=webdriver-reviewers,jdescottes,jgraham
https://hg.mozilla.org/integration/autoland/rev/44bfb901cc09
[remote] Rename webdriverBiDi to webDriverBiDi. r=webdriver-reviewers,jdescottes

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/5bdb798c3b70
https://hg.mozilla.org/mozilla-central/rev/44bfb901cc09

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The patches on this bug missed to add the WebDriverBiDiConnection.jsm to the jar.mn file, and as such new WebSocket connections via the webSocketUrl opt-in are not possible. I'm going to reopen this bug for a quick follow-up patch.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1691446 - [remote] Add WebDriverBiDiConnection.jsm to jar.mn.

Previous patches on this bug missed to actually add this file.
As such new WebSocket connections are not possible right now.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f9137c47b5ce
[remote] Add WebDriverBiDiConnection.jsm to jar.mn. r=webdriver-reviewers,jdescottes

Comment 9

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/f9137c47b5ce

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Adding to the triage list in case we want to drop the number of points to 8. I would suggest that because some parts of the work have been already split-off into their own bugs.