Closed Bug 1691446 Opened 7 months ago Closed 2 months ago

Implement Session for WebDriver BiDi

Categories

(Remote Protocol :: WebDriver BiDi, task, P2)

task
Points:
8

Tracking

(firefox92 fixed)

RESOLVED FIXED
92 Branch
Tracking Status
firefox92 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

(Blocks 3 open bugs, )

Details

(Whiteboard: [bidi-m1-mvp])

Attachments

(3 files)

For the WebDriver BiDi implementation the Session handling will be identical to our WebDriver implementation (Marionette). As such the previously moved Session related files (bug 1691414) can now be used.

This bug covers the necessary implementation work to get the WebDriver Session support implemented. Hereby we have to make sure that the active session needs to be shared with Marionette, and both protocols operate on the same session data.

Note that in case of session creation through Marionette the BiDi implementation has to use the already existent session. But there are also cases when Marionette is not used and the websocket connection is made available by starting Firefox with the command line argument --remote-debugging-port. Hereby BiDi has to create the session.

Maybe it would be best to have the Session implemented as a singleton.

Component: Agent → WebDriver BiDi
Points: --- → 13
Blocks: 1691396
No longer blocks: 1691399
Blocks: 1693830
No longer blocks: 1691396
Blocks: 1693836
Depends on: 1693805
Depends on: 1693812
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Depends on: 1719833
Blocks: 1692984
Attachment #9230534 - Attachment description: Bug 1691446 - [remote] Add support for handling WebDriverSession to WebDriver BiDi. → WIP: Bug 1691446 - [remote] Add support for handling WebDriverSession to WebDriver BiDi.
Attachment #9230534 - Attachment description: WIP: Bug 1691446 - [remote] Add support for handling WebDriverSession to WebDriver BiDi. → Bug 1691446 - [remote] Add support for handling WebDriverSession to WebDriver BiDi.
Attachment #9230534 - Attachment description: Bug 1691446 - [remote] Add support for handling WebDriverSession to WebDriver BiDi. → WIP: Bug 1691446 - [remote] Add support for handling WebDriverSession to WebDriver BiDi.
Attachment #9230534 - Attachment description: WIP: Bug 1691446 - [remote] Add support for handling WebDriverSession to WebDriver BiDi. → Bug 1691446 - [remote] Add support for handling WebDriverSession to WebDriver BiDi.
Blocks: 1720707
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5bdb798c3b70
[remote] Add support for handling WebDriverSession to WebDriver BiDi. r=webdriver-reviewers,jdescottes,jgraham
https://hg.mozilla.org/integration/autoland/rev/44bfb901cc09
[remote] Rename webdriverBiDi to webDriverBiDi. r=webdriver-reviewers,jdescottes
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch

The patches on this bug missed to add the WebDriverBiDiConnection.jsm to the jar.mn file, and as such new WebSocket connections via the webSocketUrl opt-in are not possible. I'm going to reopen this bug for a quick follow-up patch.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Previous patches on this bug missed to actually add this file.
As such new WebSocket connections are not possible right now.

Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f9137c47b5ce
[remote] Add WebDriverBiDiConnection.jsm to jar.mn. r=webdriver-reviewers,jdescottes
Status: REOPENED → RESOLVED
Closed: 2 months ago2 months ago
Resolution: --- → FIXED

Adding to the triage list in case we want to drop the number of points to 8. I would suggest that because some parts of the work have been already split-off into their own bugs.

Whiteboard: [bidi-m1-mvp] → [bidi-m1-mvp][webdriver:triage]
Points: 13 → 8
Whiteboard: [bidi-m1-mvp][webdriver:triage] → [bidi-m1-mvp]
You need to log in before you can comment on or make changes to this bug.