1691516 - Experiment Store Sync cache should store each feature pref separately

Status: RESOLVED FIXED

(Firefox :: Nimbus Desktop Client, enhancement, P1)

Comment 1

[Andrei Oprea [:andreio]]

Attachment: Bug 1691516 - Experiment Store Sync cache should store each feature pref separately

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f247372f7ab
Experiment Store Sync cache should store each feature pref separately r=k88hudson

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/6f247372f7ab

Comment 4

[Cosmin Sabou [:CosminS]]

Backed out for causing a spike on windows mochitest jobs failure rate for Bug 1276456 and Bug 1630974.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&searchStr=win%2Cmochitest&revision=6f247372f7ab394b6363684d81040715cf2a28a1&selectedTaskRun=CJVYg-RtRzqnVaMQZVa87Q.0

Failure logs: https://treeherder.mozilla.org/logviewer?job_id=330062553&repo=autoland
https://treeherder.mozilla.org/logviewer?job_id=330046342&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/fc74eb2c7b844552ae57a81dc635f413767deeb8

Spike in Bug 1276456: https://treeherder.mozilla.org/intermittent-failures/bugdetails?startday=2021-02-09&endday=2021-02-16&tree=trunk&bug=1276456
Spike in Bug 1630974: https://treeherder.mozilla.org/intermittent-failures/bugdetails?startday=2021-02-09&endday=2021-02-16&tree=trunk&bug=1630974

Comment 5

[Simon Giesecke [:sg] [he/him]]

When running xpcshell tests such as those from dom/localstorage/test/unit, I have seen messages such as

 0:33.95 GECKO(1368) [Child 1522, Main Thread] ###!!! ASSERTION: ENSURE_PARENT_PROCESS: called ClearUser on messaging-system.syncdatastore.data in a non-parent process: 'Error', file /home/simon/work/mozilla-unified/modules/libpref/Preferences.cpp:4902

which also seem related to this.

Comment 6

[Andrei Oprea [:andreio]]

Yes, I've seen that. Also:

WARNING: NS_ENSURE_TRUE(Preferences::InitStaticMembers()) failed

From calling getStringPref without a default (as far as I can tell).
Doing a try run now to see if it helps.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e8baad3aedc4
Experiment Store Sync cache should store each feature pref separately r=k88hudson

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/e8baad3aedc4