Ensure touch mode looks good
Categories
(Firefox :: Address Bar, task, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox89 | --- | verified |
People
(Reporter: bugzilla, Assigned: bugzilla)
References
(Blocks 1 open bug)
Details
(Whiteboard: [proton-address-bar])
Attachments
(1 file)
|
Assignee | |
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Comment 1•3 years ago
|
||
I audited Nightly with bug 1699229 applied. Touch mode looks good. There's no change in spacing in the panel between Proton and non-Proton. The only change I'm going to make is to make the Urlbar slightly taller. In current Proton, the Urlbar is always 32px tall, so the space between the Urlbar and the edge of the toolbar increases in Touch mode. In non-Proton, we make the Urlbar 2px taller so that the spacing between the Urlbar and the edge of the toolbar is the same between Normal and Touch modes. This also has the effect of making the Urlbar a larger tap target in Touch mode.
|
|
Assignee | |
Comment 2•3 years ago
|
||
I also tried setting the height to 36px and removing the padding-block override. I didn't think it looked very good. I like that there's slightly more padding around the Urlbar in Touch mode. It makes the UI feel roomy instead of inflated.
Pushed by htwyford@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ba57b5440804 Increase urlbar-min-height to 34px in Touch mode. r=mak
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
|
||
Comment 5•3 years ago
|
||
Touchmode was also included in the proton sign off. This was tested using a YOGA device with a windows 10 OS.
Description
•