Closed Bug 1691558 Opened 5 years ago Closed 4 years ago

Intermittent 0:18.44 tools/lint/test/test_perfdocs.py::test_perfdocs_gatherer_fetch_perfdocs_tree[perfdocs] TEST-UNEXPECTED-FAIL

Categories

(Testing :: Performance, defect, P5)

defect

Tracking

(firefox90 fixed)

RESOLVED FIXED
90 Branch
Tracking Status
firefox90 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: sparky)

References

Details

(Keywords: intermittent-failure)

Attachments

(3 files)

Filed by: nbeleuzu [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=329260590&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/Boj47E6hRM-Lp4-frtqoCg/runs/0/artifacts/public/logs/live_backing.log


[task 2021-02-08T19:10:00.765Z]  0:18.44 platform darwin -- Python 3.7.4, pytest-3.6.2, py-1.5.4, pluggy-0.6.0 -- /Users/cltbld/tasks/task_1612811089/checkouts/gecko/obj-x86_64-apple-darwin18.6.0/_virtualenvs/python-test/bin/python
[task 2021-02-08T19:10:00.765Z]  0:18.44 rootdir: /Users/cltbld/tasks/task_1612811089/checkouts/gecko, inifile: /Users/cltbld/tasks/task_1612811089/checkouts/gecko/config/mozunit/mozunit/pytest.ini
[task 2021-02-08T19:10:00.766Z]  0:18.44 collecting ... collected 19 items
[task 2021-02-08T19:10:00.766Z]  0:18.44 
[task 2021-02-08T19:10:00.766Z]  0:18.44 tools/lint/test/test_perfdocs.py::test_perfdocs_start_and_fail[perfdocs] PASSED
[task 2021-02-08T19:10:00.766Z]  0:18.44 tools/lint/test/test_perfdocs.py::test_perfdocs_start_and_pass[perfdocs] PASSED
[task 2021-02-08T19:10:00.766Z]  0:18.44 tools/lint/test/test_perfdocs.py::test_perfdocs_bad_paths[perfdocs] PASSED
[task 2021-02-08T19:10:00.766Z]  0:18.44 tools/lint/test/test_perfdocs.py::test_perfdocs_gatherer_fetch_perfdocs_tree[perfdocs] TEST-UNEXPECTED-FAIL
[task 2021-02-08T19:10:00.766Z]  0:18.44 tools/lint/test/test_perfdocs.py::test_perfdocs_gatherer_get_test_list[perfdocs] TEST-UNEXPECTED-FAIL
[task 2021-02-08T19:10:00.766Z]  0:18.44 tools/lint/test/test_perfdocs.py::test_perfdocs_verification[perfdocs] TEST-UNEXPECTED-FAIL
[task 2021-02-08T19:10:00.766Z]  0:18.44 tools/lint/test/test_perfdocs.py::test_perfdocs_verifier_validate_yaml_pass[perfdocs] PASSED
[task 2021-02-08T19:10:00.766Z]  0:18.44 tools/lint/test/test_perfdocs.py::test_perfdocs_verifier_invalid_yaml[perfdocs] PASSED
[task 2021-02-08T19:10:00.766Z]  0:18.44 tools/lint/test/test_perfdocs.py::test_perfdocs_verifier_validate_rst_pass[perfdocs] PASSED
[task 2021-02-08T19:10:00.766Z]  0:18.44 tools/lint/test/test_perfdocs.py::test_perfdocs_verifier_invalid_rst[perfdocs] PASSED
[task 2021-02-08T19:10:00.766Z]  0:18.44 tools/lint/test/test_perfdocs.py::test_perfdocs_verifier_validate_descriptions_pass[perfdocs] TEST-UNEXPECTED-FAIL
[task 2021-02-08T19:10:00.766Z]  0:18.44 tools/lint/test/test_perfdocs.py::test_perfdocs_verifier_not_existing_suite_in_test_list[perfdocs] TEST-UNEXPECTED-FAIL
[task 2021-02-08T19:10:00.766Z]  0:18.44 tools/lint/test/test_perfdocs.py::test_perfdocs_verifier_not_existing_tests_in_suites[perfdocs] TEST-UNEXPECTED-FAIL
[task 2021-02-08T19:10:00.767Z]  0:18.44 tools/lint/test/test_perfdocs.py::test_perfdocs_verifier_missing_contents_in_suite[perfdocs] TEST-UNEXPECTED-FAIL
[task 2021-02-08T19:10:00.767Z]  0:18.44 tools/lint/test/test_perfdocs.py::test_perfdocs_verifier_invalid_dir[perfdocs] PASSED
[task 2021-02-08T19:10:00.767Z]  0:18.44 tools/lint/test/test_perfdocs.py::test_perfdocs_verifier_file_invalidation[perfdocs] TEST-UNEXPECTED-FAIL
[task 2021-02-08T19:10:00.767Z]  0:18.44 tools/lint/test/test_perfdocs.py::test_perfdocs_framework_gatherers[perfdocs] PASSED
[task 2021-02-08T19:10:00.767Z]  0:18.44 tools/lint/test/test_perfdocs.py::test_perfdocs_framework_gatherers_urls[perfdocs] TEST-UNEXPECTED-FAIL
[task 2021-02-08T19:10:00.767Z]  0:18.44 tools/lint/test/test_perfdocs.py::test_perfdocs_logger_failure[perfdocs] PASSED```

Moving to performance since we are the owners of perfdocs.

Component: Lint and Formatting → Performance
Product: Firefox Build System → Testing
See Also: → 1692843, 1687754, 1692844
See Also: 1692843, 1687754, 1692844
Assignee: nobody → gmierz2
Status: NEW → ASSIGNED
Keywords: leave-open
Pushed by gmierz2@outlook.com: https://hg.mozilla.org/integration/autoland/rev/4c90462c1a56 Disable perfdocs linting tests on windows and mac. r=sylvestre
Attachment #9207319 - Attachment description: Bug 1691558 - Strength a log to confirm that the file will be searched r=sparky → Bug 1691558 - Strengthen a log to confirm that the file will be searched r=sparky
Pushed by gmierz2@outlook.com: https://hg.mozilla.org/integration/autoland/rev/866067c51ed6 Strengthen a log to confirm that the file will be searched r=sparky
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: leave-open
Resolution: --- → FIXED

sparky, there has been a recent appeareance of this bug, is it ok to reopen it?

Flags: needinfo?(gmierz2)

Hello Alexandru, Thanks for letting me know :)

Sparky, Could you re-open it?
I found the reason why It happens Intermittent exceptions.

When the test is started, It makes a temp directory using temp-file library.
Sometimes temp directory path includes hg path [0].

And then, We have 3 items to exclude path [1], when It tries to find perfdocs directory during making perfdocs.
The problem is here. [2]
dot(.hg ) is recognized to regex-metacharacter while re.search is working.
dot meaning is to find the any character.

Therefore, If the path includes the hg [0], It can't find the target directory and file because of continue logic.

[0]
/var/folders/cf/0jwlx5tx3x7_6dsrx38vbslm000017/T/tmp4fhgl5cj/perfdocs/config.yml

[1]
https://searchfox.org/mozilla-central/source/tools/lint/perfdocs/gatherer.py#77-79

[2]
https://searchfox.org/mozilla-central/source/tools/lint/perfdocs/gatherer.py#84-85

Yup definitely! I thought this was a stale failure.

Status: RESOLVED → REOPENED
Flags: needinfo?(gmierz2)
Resolution: FIXED → ---
Attachment #9216073 - Attachment description: Bug 1691558 - Using escape character to find the exact path r=sparky → Bug 1691558 - Using an escape character to find the exact path r=sparky
Pushed by gmierz2@outlook.com: https://hg.mozilla.org/integration/autoland/rev/e88b02f0a476 Using an escape character to find the exact path r=sparky
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: