1691571 - [wpt-sync] Sync PR 27537 - [TablesNG] clusterfuzz: inconstistent NG/Legacy tree

Status: RESOLVED FIXED

(Core :: Layout: Tables, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 27537 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27537
Details from upstream follow.

b'Aleks Totic <[e-mail]>' wrote:

[TablesNG] clusterfuzz: inconstistent NG/Legacy tree

When:

• DIALOG has display:table-row-group
• DIALOG is forced into Legacy layout.
• DIALOG gets shown with showModal.

We end up with a
LayoutNGTable
LayoutTableSection

This is because CreateAnonymousTableWithParent gets a hint
of whether it should be NG or Legacy from parent (#document),
and not its future child (LayoutTableSection).

Fix: pass through a variable to force legacy if needed.

Bug: 1175222
Change-Id: I7898f70f9a8d98797d4289bb3050c82514010033
Reviewed-on: https://chromium-review.googlesource.com/2683044
WPT-Export-Revision: 107f63116ba89623b60c7ebc37188252a6eabe4b

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=a97df0bfbc41bcfa2f0dd68e50161521c4a79d72

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 14 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5bfbb360f1b3
[wpt PR 27537] - [TablesNG] clusterfuzz: inconstistent NG/Legacy tree, a=testonly

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9426ddcde708
[wpt PR 27537] - [TablesNG] clusterfuzz: inconstistent NG/Legacy tree, a=testonly

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/9426ddcde708