Closed Bug 1691590 Opened 3 years ago Closed 3 years ago

Fix and re-enable devtools/shared/resources/tests/browser_resources_stylesheets.js test for Fission

Categories

(DevTools :: Framework, defect)

defect

Tracking

(Fission Milestone:M7, firefox87 fixed)

RESOLVED FIXED
87 Branch
Fission Milestone M7
Tracking Status
firefox87 --- fixed

People

(Reporter: cpeterson, Assigned: nchevobbe)

References

(Blocks 1 open bug)

Details

(Whiteboard: dt-fission-m3-mvp)

Attachments

(1 file)

This test was disabled for Fission in bug 1675020.

https://searchfox.org/mozilla-central/rev/7067bbd8194f4346ec59d77c33cd88f06763e090/devtools/shared/resources/tests/browser.ini#47-48

[browser_resources_stylesheets.js]
skip-if = fission # Disable frequent fission intermittents Bug 1675020

The Bugbug bot thinks this bug should belong to the 'DevTools::Framework' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Component: General → Framework
Whiteboard: dt-fission-triage → dt-fission-m3-triage
Whiteboard: dt-fission-m3-triage → dt-fission-m3-mvp

Tracking DevTools test bugs for Fission M8 (blocking Release experiment).

Fission Milestone: ? → M8
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED

The test was assuming that resources are coming in a constant order, which is not
the case. We use find to retrieve the resource we want instead.
There was another weird intermittent with the media query induced resource update
not being triggered. It looks like the resourceId that was used, a simple count
increment, could lead to duplicate ids that would mess with the other methods
of the watcher. Including the target actorID in the resourceId seems to fix the issue.

Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c8b79498602d
[devtools] Fix intermittent failure on devtools/shared/resources/tests/browser_resources_stylesheets.js. r=jdescottes.
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch

This completed dt-fission-m3-mvp bug should have Fission Milestone M7 Beta.

Fission Milestone: M8 → M7
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: