1691684 - Perma UntrustedModulesFixture.Serialize | Expected equality of these values:

Status: RESOLVED FIXED

(Firefox :: Launcher Process, defect, P5)

Description

Filed by: archaeopteryx [at] coole-files.de
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=329017336&repo=mozilla-beta
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/PqhfsQ5cQEKP7exVIcXgfQ/runs/0/artifacts/public/logs/live_backing.log

---

This fails permanently for late betas in the Windows 10 x64 asan configuration. This task run as tier 3 which means it is not monitored by sheriffed but still gets picked up by scans for permanent failures.

[task 2021-02-05T16:20:14.056Z] 16:20:14     INFO -  TEST-START | UntrustedModulesFixture.Serialize
[task 2021-02-05T16:20:16.359Z] 16:20:16     INFO -  Received data. (pendingQueries=199)
[task 2021-02-05T16:20:16.403Z] 16:20:16     INFO -  Received data. (pendingQueries=198)
[task 2021-02-05T16:20:16.411Z] 16:20:16  WARNING -  TEST-UNEXPECTED-FAIL | UntrustedModulesFixture.Serialize | Expected equality of these values:
[task 2021-02-05T16:20:16.412Z] 16:20:16     INFO -    sInitLoadDataCollector.Collect(waitForTwo)
[task 2021-02-05T16:20:16.412Z] 16:20:16     INFO -      Which is: 4-byte object <04-40 00-80>
[task 2021-02-05T16:20:16.412Z] 16:20:16     INFO -    NS_OK
[task 2021-02-05T16:20:16.413Z] 16:20:16     INFO -      Which is: 4-byte object <00-00 00-00> @ /builds/worker/checkouts/gecko/toolkit/xre/test/gtest/TestUntrustedModules.cpp:293
[task 2021-02-05T16:20:16.472Z] 16:20:16     INFO -  Received data. (pendingQueries=9)
[task 2021-02-05T16:20:16.504Z] 16:20:16     INFO -  Received data. (pendingQueries=6)
[task 2021-02-05T16:20:16.536Z] 16:20:16     INFO -  Received data. (pendingQueries=13)
[task 2021-02-05T16:20:16.539Z] 16:20:16  WARNING -  TEST-UNEXPECTED-FAIL | UntrustedModulesFixture.Serialize | test completed (time: 2485ms)```

Comment 1

[Toshihito Kikuchi [:toshi]]

I could not reproduce this error. I tried to kick a Try job on mozilla-beta, but GTest for Win10 ASan did not run. I also ran GTest on my local ASan build of mozilla-beta, but it finished successfully.

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Adding it manually with the "Add New Jobs" command from Treeherder's push menu worked - the test is failing.

Comment 3

[Toshihito Kikuchi [:toshi]]

Ah, I forgot to toggle tier3 jobs.

Comment 4

[Toshihito Kikuchi [:toshi]]

Attachment: Bug 1691684 - Increase kMaximumPendingQueries to wait for expected loading events longer. r=mhowell

This is a test-only change.

The "UntrustedModulesFixture.Serialize" test fails on ASan build of mozilla-beta
and mozilla-release because the current value of waiting cycles 200 is not enough
to collect all expected loading events, while it's enough on the normal build or
mozilla-central.

This patch is simply to increase the number of cycles to 500. Test logs show
ASan build of mozilla-betal or mozilla-release needs about 250 cycles to collect
all expected loading events, so 500 should be enough.

Comment 5

[Toshihito Kikuchi [:toshi]]

I confirmed Increasing kMaximumPendingQueries solved the problem. The log message like Received data. (pendingQueries=248) means kMaximumPendingQueries needs to be at least 250 for ASan build of beta or release.

beta: https://treeherder.mozilla.org/jobs?repo=try&tier=1%2C2%2C3&revision=4482e6550dc868a1fecd47a31fabb5d4134aaad6
release: https://treeherder.mozilla.org/jobs?repo=try&tier=1%2C2%2C3&revision=1533684c4c72260d265581e629db73146ee40ce1

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a613e6373e75
Increase kMaximumPendingQueries to wait for expected loading events longer.  r=mhowell

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/a613e6373e75