Closed Bug 1691764 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 27549 - Revert "Update registration-schedule-job.https.html to reflect the spec"

Categories

(Core :: DOM: Service Workers, task, P4)

task

Tracking

()

RESOLVED FIXED
87 Branch
Tracking Status
firefox87 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 27549 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27549
Details from upstream follow.

b'Christian Dullweber <dullweber@chromium.org>' wrote:

Revert "Update registration-schedule-job.https.html to reflect the spec"

This reverts commit cf04532ef9c4b904f22d1307bd924b90bbbe4ddb.

Reason for revert: The test started failing on mac after CL landed:
https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.12%20Tests/41681/overview

Original change's description:

Update registration-schedule-job.https.html to reflect the spec

Previously, the test expectation didn't comply with the spec because it
expected there's an installing worker even if register() actually didn't
install a new worker.
This CL is to update the expectation to wait for each register() call
resolved one by one. This should work because each job must not be
coalesced so the states should be updated correctly when those promises
are resolved.

Bug: 979593
Change-Id: Ib3874e7e15ebb0dfa5608cc2ff4d3484cffd72b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2679094
Commit-Queue: Makoto Shimazu \<shimazu@chromium.org>
Reviewed-by: Asami Doi \<asamidoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#852157}

TBR=shimazu@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,asamidoi@chromium.org

Change-Id: Icb7c609f6b8a44b55ae338255058679d7fa55624
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 979593
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2684257
Reviewed-by: Christian Dullweber \<dullweber@chromium.org>
Commit-Queue: Christian Dullweber \<dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#852210}

Component: web-platform-tests → DOM: Service Workers
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 2 subtests

Status Summary

Firefox

OK : 1
FAIL: 2

Chrome

OK : 1
FAIL: 2

Safari

OK : 1
FAIL: 2

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/service-workers/service-worker/registration-schedule-job.https.html
different scriptURL and updateViaCache: FAIL (Chrome: FAIL, Safari: FAIL)
different type: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c0d451a66d53
[wpt PR 27549] - Revert "Update registration-schedule-job.https.html to reflect the spec", a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c498c025859e
[wpt PR 27549] - Revert "Update registration-schedule-job.https.html to reflect the spec", a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in before you can comment on or make changes to this bug.