1691894 - Implement nsBaseHashtable::GetOrInsertWith and nsBaseHashtable::GetOrInsert with a user-defined value

Status: RESOLVED FIXED

(Core :: XPCOM, task)

Description

[Simon Giesecke [:sg] [he/him]]

Currently, nsBaseHashtable::GetOrInsert default-constructs a value, so in cases where a different value should be inserted or the DataType isn't default-constructible, the more verbose WithEntryHandle must be used. Allowing to specify a user-defined value with nsBaseHashtable::GetOrInsert resp. a factory with nsBaseHashtable::GetOrInsertWith would allow to simplify code.

Comment 1

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1691894 - Make nsUniquePtrConverter compatible with WithEntryHandle. r=#xpcom-reviewers

Comment 2

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1691894 - Implement nsBaseHashtable::GetOrInsertWith and nsBaseHashtable::GetOrInsert with user-defined constructor arguments. r=#xpcom-reviewers

Depends on D104672

Comment 3

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1691894 - Simplify uses of GetOrInsert where non-default-constructed entries are eventually inserted. r=#xpcom-reviewers

Depends on D104673

Comment 4

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1691894 - Replace use of GetOrInsert by WithEntryHandle. r=#dom-workers

Depends on D104674

Comment 5

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1691894 - Simplify uses of WithEntryHandle that only use OrInsert(With) by using GetOrInsertWith. r=#xpcom-reviewers

Depends on D104675

Comment 6

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1691894 - Fix EntryHandle to only work with DataType rather than wrapping UserDataType. r=#xpcom-reviewers

Comment 7

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1691894 - Replace several suboptimal uses of Put after Get by GetOrInsertWith or WithEntryHandle. r=#xpcom-reviewers

Depends on D104676

Comment 8

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1691894 - Make Put accept DataType instead of wrapping UserDataType. r=#xpcom-reviewers

Depends on D104849

Comment 9

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1691894 - Remove nsClassHashtable::LookupForAddFromFactory and use GetOrInsertWith instead. r=#xpcom-reviewers

Depends on D104850

Comment 10

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1691894 - Always hold PrefCallback in a UniquePtr in nsPrefBranch::AddObserverImpl. r=KrisWright

Depends on D104851

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5213eb40bb50
Fix EntryHandle to only work with DataType rather than wrapping UserDataType. r=xpcom-reviewers,necko-reviewers,nika,jonco,valentin
https://hg.mozilla.org/integration/autoland/rev/72d7d50c86aa
Replace use of GetOrInsert by WithEntryHandle. r=dom-worker-reviewers,janv

Comment 12

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/5213eb40bb50
https://hg.mozilla.org/mozilla-central/rev/72d7d50c86aa

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/db4503476f34
Implement nsBaseHashtable::GetOrInsertWith and nsBaseHashtable::GetOrInsert with user-defined constructor arguments. r=xpcom-reviewers,nika
https://hg.mozilla.org/integration/autoland/rev/f977d6cfa973
Replace several suboptimal uses of Put after Get by GetOrInsertWith or WithEntryHandle. r=xpcom-reviewers,necko-reviewers,kmag,valentin,geckoview-reviewers,agi
https://hg.mozilla.org/integration/autoland/rev/7483e84149d8
Make Put accept DataType instead of wrapping UserDataType. r=xpcom-reviewers,necko-reviewers,nika
https://hg.mozilla.org/integration/autoland/rev/58c31e9d6ae3
Remove nsClassHashtable::LookupForAddFromFactory and use GetOrInsertWith instead. r=xpcom-reviewers,nika
https://hg.mozilla.org/integration/autoland/rev/22dc870ee609
Always hold PrefCallback in a UniquePtr in nsPrefBranch::AddObserverImpl. r=KrisWright

Comment 14

[Sandor Molnar[:smolnar]]

Backed out for causing hazard failures in nsXULPrototypeCache

Backout link: https://hg.mozilla.org/integration/autoland/rev/6ee7daf9a461d51c9ef7b70e177074d2e568f30f

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunning%2Cpending%2Crunnable&revision=f1e025de3da2e4c3820722ad301f6896f30c135a&selectedTaskRun=JAj_4aWjSrWNNkf7KyhDmw.2

Failure log: https://treeherder.mozilla.org/logviewer?job_id=329997413&repo=autoland&lineNumber=18186

Comment 15

[Simon Giesecke [:sg] [he/him]]

Re-landed the two patches before the regression from comment 14 was introduced.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/88c07c36a9f3
Implement nsBaseHashtable::GetOrInsertWith and nsBaseHashtable::GetOrInsert with user-defined constructor arguments. r=xpcom-reviewers,nika
https://hg.mozilla.org/integration/autoland/rev/5dcb40e333f1
Replace several suboptimal uses of Put after Get by GetOrInsertWith or WithEntryHandle. r=xpcom-reviewers,necko-reviewers,kmag,valentin,geckoview-reviewers,agi

Comment 17

[Simon Giesecke [:sg] [he/him]]

The offending patch will be moved to Bug 1692880.

Comment 18

[Phabricator Automation]

Comment on attachment 9202637 [details]
Bug 1691894 - Make Put accept DataType instead of wrapping UserDataType. r=#xpcom-reviewers

Revision D104850 was moved to bug 1692880. Setting attachment 9202637 [details] to obsolete.

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e884c5cba34
Remove nsClassHashtable::LookupForAddFromFactory and use GetOrInsertWith instead. r=xpcom-reviewers,nika
https://hg.mozilla.org/integration/autoland/rev/9985953875a4
Always hold PrefCallback in a UniquePtr in nsPrefBranch::AddObserverImpl. r=KrisWright
https://hg.mozilla.org/integration/autoland/rev/62ca610656d6
Simplify uses of GetOrInsert where non-default-constructed entries are eventually inserted. r=xpcom-reviewers,necko-reviewers,nika,valentin

Comment 20

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/88c07c36a9f3
https://hg.mozilla.org/mozilla-central/rev/5dcb40e333f1
https://hg.mozilla.org/mozilla-central/rev/2e884c5cba34
https://hg.mozilla.org/mozilla-central/rev/9985953875a4
https://hg.mozilla.org/mozilla-central/rev/62ca610656d6

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ffdf55cd2080
Simplify uses of WithEntryHandle that only use OrInsert(With) by using GetOrInsertWith. r=xpcom-reviewers,necko-reviewers,jgilbert,nika

Comment 22

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/ffdf55cd2080