1691925 - Block webrender on android devices which don't support GL_OES_EGL_image_external_essl3

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task)

Description

[Jamie Nicol [:jnicol]]

As seen in bug 1507074, there are some GLES 3 devices which do not support the extension GL_OES_EGL_image_external_essl3. This means that we get a shader compilation error when attempting to render video (and webgl I think), then we fall back to OpenGL layers.

In bug 1507074 we will attempt to find a long-term solution, but for now let's block webrender on devices without this extension.

Comment 1

[Jamie Nicol [:jnicol]]

Attachment: Bug 1691925 - Block webrender on android devices which don't support GL_OES_EGL_image_external_essl3 r?aosmond

Currently webrender requires the extension
GL_OES_EGL_image_external_essl3 to render video. There exist some
older GLES 3 devices which do not support this extension, and
attempting to render video on these devices results in a shader
compilation error and falling back to OpenGL layers.

In bug 1507074 we will implement a long term solution for such
devices, but in the meantime block webrender on devices which do not
support this extension.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6bdd49767079
Block webrender on android devices which don't support GL_OES_EGL_image_external_essl3 r=aosmond

Comment 3

[Narcis Beleuzu [:NarcisB]]

Backed out for crashes on GLContext

Backout link: https://hg.mozilla.org/integration/autoland/rev/01c702b65cc993cd4c228e687c0e234c3c6f85fe
Log link: https://treeherder.mozilla.org/logviewer?job_id=329493881&repo=autoland&lineNumber=1819

Please also check crashes on GfxInfo -> https://treeherder.mozilla.org/logviewer?job_id=329494997&repo=autoland&lineNumber=1942

Comment 4

[Jamie Nicol [:jnicol]]

Ah, we can't rely on the glGetString*i* variant on all OpenGL versions, so instead we should just use glGetString() and nsCString::Split(' ') the returned value.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b0615d0577ae
Block webrender on android devices which don't support GL_OES_EGL_image_external_essl3 r=aosmond

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/b0615d0577ae