1692026 - [wpt-sync] Sync PR 27578 - dpwas:Add ongeometrychange event to WindowControlsOverlay

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 27578 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27578
Details from upstream follow.

b'Hassan Talat <[e-mail]>' wrote:

dpwas:Add ongeometrychange event to WindowControlsOverlay

For PWAs with WindowControlsOverlay, This CL adds an ongeometrychange
event for whenever the overlay bounds or visibility changes to notify
the app. An example of changing bounds would be when the app is
launched, the app origin is displayed and then hidden.

Explainer: https://github.com/WICG/window-controls-overlay/blob/master/explainer.md
Design Doc: https://docs.google.com/document/d/1k0YL_-VMLIfjYCgJ2v6cMvuUv2qMKg4BgLI2tJ4qtyo/edit?usp=sharing
I2P: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/cper6nNLFRQ/hU91kfCWBQAJ

Bug: 937121
Change-Id: Ic0f6e76883d3ec5fc98f8d1bf734e72aa49de2c2

Reviewed-on: https://chromium-review.googlesource.com/2686584
WPT-Export-Revision: 8d8af450e81fe0ce0a8455a70b387bfbc85d5a2d

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=77674aefe32f7afb73f4261bba21a9f2d02782b6

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 7 subtests

Status Summary

Firefox

OK : 1
FAIL: 7

Chrome

OK : 1
FAIL: 7

Safari

OK : 1
FAIL: 7

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/webappapis/system-state-and-capabilities/the-navigator-object/navigator-window-controls-overlay.html
the windowControlsOverlay object should exist on the navigator object: FAIL (Chrome: FAIL, Safari: FAIL)
visible should be a member of the windowControlsOverlay object: FAIL (Chrome: FAIL, Safari: FAIL)
visible should be false: FAIL (Chrome: FAIL, Safari: FAIL)
getBoundingClientRect should be a method of the windowControlsOverlay object: FAIL (Chrome: FAIL, Safari: FAIL)
getBoundingClientRect return type should be DOMRect: FAIL (Chrome: FAIL, Safari: FAIL)
getBoundingClientRect should return a empty DOMRect: FAIL (Chrome: FAIL, Safari: FAIL)
ongeometrychange should be a member of the windowControlsOverlay object: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f5ec3cb7447e
[wpt PR 27578] - dpwas:Add ongeometrychange event to WindowControlsOverlay, a=testonly
https://hg.mozilla.org/integration/autoland/rev/a3f2ade037b5
[wpt PR 27578] - Update wpt metadata, a=testonly

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/f5ec3cb7447e
https://hg.mozilla.org/mozilla-central/rev/a3f2ade037b5