Improve context menu extension icon styling
Categories
(Firefox :: Menus, defect, P3)
Tracking
()
People
(Reporter: molly, Unassigned)
References
Details
(Whiteboard: [proton-context-menus] )
For the context menu style introduced by bug 1682522, icons for extension menu items that appear at the end of the content area context menu are vertically aligned with the text for items that don't have any icons. This may or may not be what we end up wanting.
|
Reporter | |
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
||
Comment 1•3 years ago
|
||
(In reply to Molly Howell (she/her) [:mhowell] from comment #0)
icons for extension menu items that appear at the end of the content area context menu are vertically aligned with the text for items that don't have any icons.
To be clear, you mean that (in LTR languages like English) the left-hand side of the webextension menuitem's icon aligns with the start of the text in menuitems (without icons) above it, right?
Or do you mean that the icon's vertical position (top? middle? bottom?) is aligned with the text in a particular way?
|
|
Reporter | |
Comment 2•3 years ago
|
||
(In reply to :Gijs (he/him) from comment #1)
(In reply to Molly Howell (she/her) [:mhowell] from comment #0)
icons for extension menu items that appear at the end of the content area context menu are vertically aligned with the text for items that don't have any icons.
To be clear, you mean that (in LTR languages like English) the left-hand side of the webextension menuitem's icon aligns with the start of the text in menuitems (without icons) above it, right?
I meant this one, yes. Doing it that way seemed fine for now, but I wasn't sure if the final spec would be different.
|
|
||
Comment 3•3 years ago
|
||
(In reply to Molly Howell (she/her) [:mhowell] from comment #2)
(In reply to :Gijs (he/him) from comment #1)
(In reply to Molly Howell (she/her) [:mhowell] from comment #0)
icons for extension menu items that appear at the end of the content area context menu are vertically aligned with the text for items that don't have any icons.
To be clear, you mean that (in LTR languages like English) the left-hand side of the webextension menuitem's icon aligns with the start of the text in menuitems (without icons) above it, right?
I meant this one, yes. Doing it that way seemed fine for now, but I wasn't sure if the final spec would be different.
OK, great. The spec seems to not have an explicit indication of how this should work on Windows 10, but the macOS menu aligns (hah) with this decision so I think we can just mark this done. :-)
Description
•