1692099 - File path is undefined for ExperimentStore

Status: VERIFIED FIXED

(Firefox :: Nimbus Desktop Client, defect, P1)

Description

[Kate Hudson :k88hudson]

Due to a change in the way we initialize SharedDataMap it looks like experiments are now being read from undefined.json – I think this could potentially unenroll a bunch of users across 85/86, so we probably need an uplift for this.

Comment 1

[Kate Hudson :k88hudson]

[Tracking Requested - why for this release]:

Need to investigate as to whether this causes any user-facing issues tomorrow, but I think it might cause Nimbus experiments that cross over from 85/86 to be impacted in some way.

Comment 2

[Andrei Oprea [:andreio]]

Attachment: Bug 1692099 - File path is undefined for ExperimentStore

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ec72eae5260
File path is undefined for ExperimentStore r=k88hudson

Comment 4

[Andrei Oprea [:andreio]]

Comment on attachment 9202568 [details]
Bug 1692099 - File path is undefined for ExperimentStore

Beta/Release Uplift Approval Request

• User impact if declined: Regression will cause users to unenroll from experiments when they upgrade from 85 to 86
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Enroll the profile in a Nimbus experiment using Beta 85 and then open the same profile in Nightly 86. Enrollment should still be visible in about:studies.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Covered by tests. No visible user impact. Will work with QA to get this verified.
• String changes made/needed:

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/5ec72eae5260

Comment 6

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (87.0a1 Build ID - 20210211213143) installed on Windows 10 x64, macOS 10.15.7, and Linux Mint 20 x64. Now, I can confirm that the ExperimentStoreData.json file is successfully displayed in the profile folder instead of the undefined.json one.

Comment 7

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9202568 [details]
Bug 1692099 - File path is undefined for ExperimentStore

Has tests, verified on Nightly by QA, low risk and is impacting Nimbus work, let's take it on the beta branch before the merge and have QA verify in the RC build the fix. Thanks.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0c89c72e0881

Comment 9

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Beta (86.0 Build ID - 20210215141125) installed on Windows 10 x64, macOS 10.15.7, and Linux Mint 20 x64. Now, I can confirm that the ExperimentStoreData.json file is successfully displayed in the profile folder instead of the undefined.json one.