Closed Bug 1692179 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 27590 - Revert "[TablesNG] Implement column track merging"

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox87 fixed)

Status:
RESOLVED FIXED
Milestone:
87 Branch
Tracking Flags:
Tracking Status
firefox87 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 27590 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27590
Details from upstream follow.

b'Thiemo Nagel <tnagel@chromium.org>' wrote:

Revert "[TablesNG] Implement column track merging"

This reverts commit 2dadda0cccbda46a2fffe23e8c607e88f4d45394.

Reason for revert: Suspected cause of paint/tables/huge-table-composited-scroll-collapsed-borders.html failures

https://ci.chromium.org/ui/p/chromium/builders/ci/WebKit%20Linux%20ASAN/22054

Original change's description:

[TablesNG] Implement column track merging

One the a11y requirements was that tables should do track merging.
I've skipped implementing this initially because there was major
disagreement about what to do.

This implementation follows the standard.
Columns defined by TD or COL are merged for table-layout:auto,
and not merged for table-layout:fixed.

Legacy did not follow the standard for columns defined by TDs:
they were always merged. Firefox implementation was closer to
standard, but sometimes buggy.

This changes results of some tests. Almost all of them are because
"TablesNG is more standards compliant", and new renderings match
FF.

There is disagreement about treatment of empty rows between
FF and TablesNGNG.

external/wpt/css/css-tables/html5-table-formatting-1.html
external/wpt/css/css-tables/html5-table-formatting-2.html

The rest of the changes render better, just like FF.

Two new tests have been added:
wpt/css/css-tables/column-track-merging.html
tests the standard.

accessibility/table-column-track-merging.html
tests Chrome's a11y API.

Change-Id: Ia222351f7c500963ace556d76c26fcefb1df24e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2670193
Commit-Queue: Aleks Totic \<atotic@chromium.org>
Reviewed-by: Ian Kilpatrick \<ikilpatrick@chromium.org>
Reviewed-by: David Grogan \<dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#852958}

TBR=dgrogan@chromium.org,ikilpatrick@chromium.org,atotic@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: Id914684949be4eb6196a850bb1168d25872346ef
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2690334
Reviewed-by: Thiemo Nagel \<tnagel@chromium.org>
Commit-Queue: Thiemo Nagel \<tnagel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#853075}

PR 27590 applied with additional changes from upstream: 6902c0348cafb66a237b5ce75d9b3038bd3f3f87
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1844991b6ebd
[wpt PR 27590] - Revert "[TablesNG] Implement column track merging", a=testonly
Test result changes from PR not available.
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7e61e2eb9045
[wpt PR 27590] - Revert "[TablesNG] Implement column track merging", a=testonly

https://hg.mozilla.org/mozilla-central/rev/7e61e2eb9045

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox87: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in before you can comment on or make changes to this bug.