1692199 - Perma dom/tests/mochitest/general/test_interfaces.html | If this is failing: DANGER, are you sure you want to expose the new interface EventCounts to all webpages as a property on the window? when Gecko 87 merges to Beta on 2021-02-22

Status: VERIFIED FIXED

(Core :: Performance, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

• central-as-beta simulation
• How to run these simulations
• Failure log

TEST-UNEXPECTED-FAIL | dom/tests/mochitest/general/test_interfaces.html | If this is failing: DANGER, are you sure you want to expose the new interface EventCounts to all webpages as a property on the window? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
TEST-UNEXPECTED-FAIL | dom/tests/mochitest/general/test_interfaces_secureContext.html | If this is failing: DANGER, are you sure you want to expose the new interface EventCounts to all webpages as a property on the window? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)

Comment 1

[Sean Feng [:sefeng]]

Attachment: Bug 1692199 - Performance object shouldn't create eventCounts when the pref is not set r=smaug

Upon the construction of eventCounts, a wrapper of it will be created
because we set the initial values to 0. This exposes the interface
despite the pref is not set.

Comment 2

[Sean Feng [:sefeng]]

Attachment: Bug 1692199 - Enable event-timing for test_toJSON.html test r=smaug

The test expects EventCounts to exist which the pref is required.

Depends on D104872

Comment 3

[Sean Feng [:sefeng]]

Attachment: Bug 1692199 - Make test_toJSON.html to not throw if EventCounts isn't defined r=smaug

Depends on D104872

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/44a4bda1f823
Performance object shouldn't create eventCounts when the pref is not set r=smaug,aryx
https://hg.mozilla.org/integration/autoland/rev/f11b8cb09ec6
Make test_toJSON.html to not throw if EventCounts isn't defined r=smaug

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/44a4bda1f823
https://hg.mozilla.org/mozilla-central/rev/f11b8cb09ec6

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

This is still happening in today's central as beta simulation.
https://treeherder.mozilla.org/jobs?repo=try&revision=24a466d2b0063bdaf46323c16e1d424585182923&searchStr=linux%2C18.04%2Cx64%2Cshippable%2Copt%2Cmochitests%2Ctest-linux1804-64-shippable%2Fopt-mochitest-plain-e10s%2C3&selectedTaskRun=awxlHCKTS9KAj0WKGEDrnA.0

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

The central-as-beta simulation used an old central revision.

Comment 8

[Intermittent Failures Robot]

1 failures in 4322 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 1

Platform and build breakdown:

• linux1804-64: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1692199&startday=2021-02-08&endday=2021-02-14&tree=all

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Verified fixed in today's central-as-beta simulation.