1692223 - Update unfocused state

Status: VERIFIED FIXED

(Firefox :: Address Bar, enhancement, P2)

Description

[Harry Twyford]

This is just a colour change in the default themes. The address bar will now be darker than the rest of the toolbar.

Comment 1

[Harry Twyford]

Duped from Jira:

We currently apply a subtle drop-shadow when the unfocused Urlbar is hovered. With the Proton redesign, the Urlbar appears flatter, without borders. Should we continue to apply this drop-shadow, or does that disrupt the flatter look?

I'll mark this blocked-ux because we can't land without an answer, but I'll continue working on this and post a patch for review. We can just drop the one drop-shadow rule if needed when we get an answer.

Comment 2

[Harry Twyford]

Another question duped from Jira:

We currently allow themes to set custom borders around the Urlbar. See the toolbar_field_border section at: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/theme. In the UX spec, the Urlbar has no border when unfocused. Are we dropping support for themes setting a border on the Urlbar, or will our themes just not set one?

Presumably, in the latter case, our themes would just set a transparent border so we have consistent spacing.

Comment 3

[Harry Twyford]

From UX:

The current shadow that appears on hover is very subtle. I propose we remove this drop shadow to maintain the flat appearance.

Unless it is an issue, we should support custom borders around the URL bar especially for people that currently have custom themes. Some themes have very similar colours between the URL bar and chrome and rely on the border style for visibility.

Comment 4

[Harry Twyford]

Attachment: Bug 1692223 - Add Proton styles for the unfocused address bar.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/78f0c795c492
Add Proton styles for the unfocused address bar. r=desktop-theme-reviewers,dao

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/78f0c795c492

Comment 7

[Florencia Di Ciocco, NI to vbalducci]

Hi,
Just to make sure I understood it all. With proton browser.proton.urlbar.enabled pref off I should still see the shadow that appears around the address bar on hover when the address bar is unfocused. With the proton on, I should see no shadow on hover. Am I right?

Comment 8

[Harry Twyford]

Yes, that's right.

Comment 9

[Florencia Di Ciocco, NI to vbalducci]

Thanks, then I've verified this behavior on beta 87.0b2.