1692312 - Display the contents of the GetLastError() value when showing Windows crashes that contain it

Status: RESOLVED FIXED

(Socorro :: Webapp, task, P2)

Description

[Gabriele Svelto [:gsvelto] (PTO)]

This bug is for the front-end change required to display the data we'll extract in bug 1692309. I'll add more details once that's implemented but it's going to be an optional field with a hex value and a string that gets extracted by the stack walker.

Comment 1

[Gabriele Svelto [:gsvelto] (PTO)]

With issue #16 fixed in the stack walker this can be implemented. The change in the stackwalker will cause it to include a new value in each thread called last_error_value which represents the equivalent of calling GetLastError() on that thread in Windows. The value is optional and if not present it's either because it's not supported (macOS/Linux) or because it's zero (meaning no previous operation has failed).

It would be nice to see the value in the "Details" tab if present in the crashing thread. This is just a numerical value for now. It can be translated into a set of names on Windows but I'll leave that to a follow-up bug because we need to somehow "port" the mappings into Socorro (or the stackwalker).

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

For crash reports that were processed with the updated minidump-stackwalk, it'll show up in the Raw Data and Minidumps tab in the minidump-stackwalk output.

For example, here's a crash report I kicked off last last week that I reprocessed that shows it now: bp-b7ef714d-623d-4494-a938-2d1e60210312

Is that sufficient? Do we want this showing up in some other capacity in the report view?

Comment 3

[Gabriele Svelto [:gsvelto] (PTO)]

It would be nice if we could show a line in the "Details" tab with the content of the value in the crashing thread if it is non-zero. Note that the last_value_error entry for that would be found inside the threads array, not within the crashing_thread one.

A description for that field would be something like: "The error that would have been returned by GetLastError() if it had been called in the crashing thread".

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

I can do that. I'll try to do this in the next week or two.

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

Example crash report that has a last_error_value in the crashing thread (18): bp-b1faea94-fd90-4711-babe-e44dc0210326

Comment 6

[Gabriele Svelto [:gsvelto] (PTO)]

(In reply to Will Kahn-Greene [:willkg] ET needinfo? me from comment #5)

Example crash report that has a last_error_value in the crashing thread (18): bp-b1faea94-fd90-4711-babe-e44dc0210326

That's a perfect sample. it's an OOM crash and the error value is 0x5af which Windows translates as ERROR_COMMITMENT_LIMIT. A 100% exquisitely Windows-ish failure.

Comment 7

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 5733: bug 1692312: add last error value to details tab in report index view

Comment 8

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #5733: "bug 1692312: add last error value to details tab in report index view" in 2842db4.

Comment 9

[Will Kahn-Greene [:willkg] ET needinfo? me]

I deployed this to prod just now in bug #1703541. Marking as FIXED.