Closed Bug 1692329 Opened 3 years ago Closed 3 years ago

Remove "(No login suggestions)" context menu item and hide the "Fill login" item where there are no matching saved logins

Categories

(Toolkit :: Password Manager, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
88 Branch
Tracking Status
firefox88 --- verified

People

(Reporter: sfoster, Assigned: prathiksha)

References

Details

(Keywords: helpwanted, Whiteboard: [proton-context-menus] )

Attachments

(1 file)

When we have no matching saved logins for an origin, the context menu for a username or password field currently has a "Fill login" submenu with items "(No login suggestions)" and "View Saved Logins". We want to remove the "No login suggestions" empty state item, and hide the top-level Fill login item (as, after bug 1692322 this will become an empty menu in this case.)

Summary: Move "View Saved Logins" login field context menu item to the top level, and re-label "Manage Logins..." → Remove "(No login suggestions)" context menu item and hide the "Fill login" item where there are no matching saved logins
Keywords: helpwanted
Assignee: nobody → prathikshaprasadsuman
Status: NEW → ASSIGNED
Priority: P2 → P1
Pushed by prathikshaprasadsuman@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/68865a687556
Remove (No login suggestions) context menu item and hide the use saved login item where there are no matching saved logins. r=Gijs
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch

Verified that No login suggestions is removed and Use saved login/password is available only when one or more logins are saved. Verified with latest Nightly 88.0a1 across platforms (Windows 10, macOS 11.3 and Ubuntu 18.04).

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: