Closed Bug 1692330 Opened 2 years ago Closed 2 years ago

Hide the "Add a keyword for this search" context menu item for username form fields

Categories

(Toolkit :: Password Manager, enhancement, P1)

Product:
Toolkit
Component:
Password Manager
Type:
enhancement

Tracking

()

Status:
VERIFIED FIXED
Milestone:
88 Branch
Tracking Flags:
Tracking Status
firefox88 --- verified

People

(Reporter: sfoster, Assigned: jaws)

References

Details

(Keywords: helpwanted, Whiteboard: [proton-context-menus] )

Attachments

(1 file)

Bug 1692330 - Hide the 'Add a keyword for this search' when inside of a login form.
48 bytes, text/x-phabricator-request
Details | Review

When we've identified a form input as the username field of a login form, we should hide the "Add a keyword for this search" context menu item.

Keywords: helpwanted
Assignee: nobody → jaws
Status: NEW → ASSIGNED

As per guidance from Vicky, for tracking, we're marking all the bugs that people are working on as P1.

Priority: P2 → P1
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fd7b7fe57ef1
Hide the 'Add a keyword for this search' when inside of a login form. r=Gijs

https://hg.mozilla.org/mozilla-central/rev/fd7b7fe57ef1

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox88: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch

Verified that Add a keyword for this search is not available anymore in user login forms. Verified with latest Nightly 88.0a1 across platforms (Windows 10, macOS 11.3 and Ubuntu 18.04).

Status: RESOLVED → VERIFIED
status-firefox88: fixed → verified
See Also: → 1703400
You need to log in before you can comment on or make changes to this bug.