Allow ANGLE glBlitFramebuffer implementation to handle renderbuffers without D3D11_BIND_SHADER_RESOURCE in some cases.
Categories
(Core :: Graphics, task)
Tracking
()
Tracking | Status | |
---|---|---|
firefox87 | --- | fixed |
People
(Reporter: gw, Assigned: gw)
References
Details
Attachments
(1 file, 1 obsolete file)
Assignee | ||
Comment 1•3 years ago
|
||
In some cases, it's possible to have an FBO that has a color target
renderbuffer attachment that does not have D3D11_BIND_SHADER_RESOURCE
set on the underlying D3D resource. For example, this can occur
when a DirectComposition surface texture is bound to an FBO via the
GL_OES_EGL_image
extension.
When this occurs, the D3D11 implementation of glBlitFramebuffer
can assert and fail, because it's not possible to get the readSRV
for the underlying resource.
However, under certain conditions, the implementation of
blitRenderbufferRect
hits a fast path, using CopySubresourceRegion
which doesn't rely on having a valid readSRV
.
This patch delays the allocation and assertions related to
readSRV
until it's determined that the fast path cannot be used.
This allows glBlitFramebuffer
to work for these kinds of resources
so long as the conditions for the fast path are hit.
Updated•3 years ago
|
Comment 2•3 years ago
|
||
Updated•3 years ago
|
Pushed by jgilbert@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/68a46b7ab6e9 [angle] Don't assert for non-sampleable non-ms sources in blitRenderbufferRect if we can CopySubResource. r=gw
Comment 4•3 years ago
|
||
bugherder |
Description
•