1692444 - Intermittent SUMMARY: ThreadSanitizer: data race /builds/worker/checkouts/gecko/toolkit/components/resistfingerprinting/nsRFPService.cpp:273:7 in RandomMidpoint

Status: RESOLVED FIXED

(Core :: Security, defect, P3)

Description

[Treeherder Bug Filer]

Filed by: ncsoregi [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=329746049&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/BAGVuqStSdm1qDVKlC97EQ/runs/0/artifacts/public/logs/live_backing.log

---

[task 2021-02-12T08:27:21.542Z] 08:27:21     INFO - TEST-START | /webrtc/RTCDataChannel-binaryType.window.html
[..]
[task 2021-02-12T08:27:22.776Z] 08:27:22     INFO - PID 9655 |   Location is global 'mozilla::nsRFPService::RandomMidpoint(long long, long long, long, long long*, unsigned char*)::sSecretMidpointSeed' of size 8 at 0x7f686e7768a8 (libxul.so+0x00000bb348a8)
[task 2021-02-12T08:27:22.777Z] 08:27:22     INFO - PID 9655 |   Thread T5 'Socket Thread' (tid=10304, running) created by main thread at:
[task 2021-02-12T08:27:22.784Z] 08:27:22     INFO - PID 9655 |     #0 pthread_create /builds/worker/fetches/llvm-project/llvm/projects/compiler-rt/lib/tsan/rtl/tsan_interceptors_posix.cpp:966:3 (firefox+0x5668b)
[task 2021-02-12T08:27:22.786Z] 08:27:22     INFO - PID 9655 |     #1 _PR_CreateThread /builds/worker/checkouts/gecko/nsprpub/pr/src/pthreads/ptthread.c:458:14 (libnspr4.so+0x3c3f3)
[task 2021-02-12T08:27:22.787Z] 08:27:22     INFO - PID 9655 |     #2 PR_CreateThread /builds/worker/checkouts/gecko/nsprpub/pr/src/pthreads/ptthread.c:533:12 (libnspr4.so+0x30d15)
[task 2021-02-12T08:27:22.788Z] 08:27:22     INFO - PID 9655 |     #3 nsThread::Init(nsTSubstring<char> const&) /builds/worker/checkouts/gecko/xpcom/threads/nsThread.cpp:609:18 (libxul.so+0xbb9ab8)
[task 2021-02-12T08:27:22.789Z] 08:27:22     INFO - PID 9655 |     #4 nsThreadManager::NewNamedThread(nsTSubstring<char> const&, unsigned int, nsIThread**) /builds/worker/checkouts/gecko/xpcom/threads/nsThreadManager.cpp:641:12 (libxul.so+0xbc124a)
[task 2021-02-12T08:27:22.791Z] 08:27:22     INFO - PID 9655 |     #5 NS_NewNamedThread(nsTSubstring<char> const&, nsIThread**, already_AddRefed<nsIRunnable>, unsigned int) /builds/worker/checkouts/gecko/xpcom/threads/nsThreadUtils.cpp:169:57 (libxul.so+0xbc8837)
[task 2021-02-12T08:27:22.792Z] 08:27:22     INFO - PID 9655 |     #6 NS_NewNamedThread<14> /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:85:10 (libxul.so+0xd6535f)
[task 2021-02-12T08:27:22.793Z] 08:27:22     INFO - PID 9655 |     #7 mozilla::net::nsSocketTransportService::Init() /builds/worker/checkouts/gecko/netwerk/base/nsSocketTransportService2.cpp:769:7 (libxul.so+0xd6535f)
[task 2021-02-12T08:27:22.794Z] 08:27:22     INFO - PID 9655 |     #8 mozilla::xpcom::CreateInstanceImpl(mozilla::xpcom::ModuleID, nsISupports*, nsID const&, void**) /builds/worker/workspace/obj-build/xpcom/components/StaticComponents.cpp:9157:7 (libxul.so+0xb830ac)
[task 2021-02-12T08:27:22.796Z] 08:27:22     INFO - PID 9655 |     #9 mozilla::xpcom::StaticModule::CreateInstance(nsISupports*, nsID const&, void**) const /builds/worker/workspace/obj-build/xpcom/components/StaticComponents.cpp:12363:10 (libxul.so+0xb7cca3)
[task 2021-02-12T08:27:22.797Z] 08:27:22     INFO - PID 9655 |     #10 CreateInstance /builds/worker/checkouts/gecko/xpcom/components/nsComponentManager.cpp:176:46 (libxul.so+0xb94371)
[task 2021-02-12T08:27:22.798Z] 08:27:22     INFO - PID 9655 |     #11 nsComponentManagerImpl::GetServiceLocked(mozilla::Maybe<mozilla::MonitorAutoLock>&, (anonymous namespace)::EntryWrapper&, nsID const&, void**) /builds/worker/checkouts/gecko/xpcom/components/nsComponentManager.cpp:1283:17 (libxul.so+0xb94371)
[task 2021-02-12T08:27:22.800Z] 08:27:22     INFO - PID 9655 |     #12 nsComponentManagerImpl::GetServiceByContractID(char const*, nsID const&, void**) /builds/worker/checkouts/gecko/xpcom/components/nsComponentManager.cpp:1472:10 (libxul.so+0xb94ff7)
[task 2021-02-12T08:27:22.801Z] 08:27:22     INFO - PID 9655 |     #13 CallGetService /builds/worker/checkouts/gecko/xpcom/components/nsComponentManagerUtils.cpp:61:43 (libxul.so+0xb97d8d)
[task 2021-02-12T08:27:22.810Z] 08:27:22     INFO - PID 9655 |     #14 nsGetServiceByContractIDWithError::operator()(nsID const&, void**) const /builds/worker/checkouts/gecko/xpcom/components/nsComponentManagerUtils.cpp:253:21 (libxul.so+0xb97d8d)
[task 2021-02-12T08:27:22.811Z] 08:27:22     INFO - PID 9655 |     #15 nsCOMPtr_base::assign_from_gs_contractid_with_error(nsGetServiceByContractIDWithError const&, nsID const&) /builds/worker/checkouts/gecko/xpcom/base/nsCOMPtr.cpp:91:7 (libxul.so+0xad6237)
[task 2021-02-12T08:27:22.812Z] 08:27:22     INFO - PID 9655 |     #16 operator= /builds/worker/workspace/obj-build/dist/include/nsCOMPtr.h:774:5 (libxul.so+0xd0ad11)
[task 2021-02-12T08:27:22.813Z] 08:27:22     INFO - PID 9655 |     #17 InitializeSocketTransportService /builds/worker/checkouts/gecko/netwerk/base/nsIOService.cpp:436:29 (libxul.so+0xd0ad11)
[task 2021-02-12T08:27:22.814Z] 08:27:22     INFO - PID 9655 |     #18 mozilla::net::nsIOService::SetOffline(bool) /builds/worker/checkouts/gecko/netwerk/base/nsIOService.cpp:1306:7 (libxul.so+0xd0ad11)
[task 2021-02-12T08:27:22.814Z] 08:27:22     INFO - PID 9655 |     #19 mozilla::net::nsIOService::Init() /builds/worker/checkouts/gecko/netwerk/base/nsIOService.cpp:319:3 (libxul.so+0xd09fae)
[task 2021-02-12T08:27:22.815Z] 08:27:22     INFO - PID 9655 |     #20 mozilla::net::nsIOService::GetInstance() /builds/worker/checkouts/gecko/netwerk/base/nsIOService.cpp:493:9 (libxul.so+0xd0bad1)
[task 2021-02-12T08:27:22.816Z] 08:27:22     INFO - PID 9655 |     #21 mozilla::xpcom::CreateInstanceImpl(mozilla::xpcom::ModuleID, nsISupports*, nsID const&, void**) /builds/worker/workspace/obj-build/xpcom/components/StaticComponents.cpp:12082:48 (libxul.so+0xb8245f)
[task 2021-02-12T08:27:22.820Z] 08:27:22     INFO - PID 9655 |     #22 mozilla::xpcom::StaticModule::CreateInstance(nsISupports*, nsID const&, void**) const /builds/worker/workspace/obj-build/xpcom/components/StaticComponents.cpp:12363:10 (libxul.so+0xb7cca3)
[task 2021-02-12T08:27:22.821Z] 08:27:22     INFO - PID 9655 |     #23 CreateInstance /builds/worker/checkouts/gecko/xpcom/components/nsComponentManager.cpp:176:46 (libxul.so+0xb94371)
[task 2021-02-12T08:27:22.822Z] 08:27:22     INFO - PID 9655 |     #24 nsComponentManagerImpl::GetServiceLocked(mozilla::Maybe<mozilla::MonitorAutoLock>&, (anonymous namespace)::EntryWrapper&, nsID const&, void**) /builds/worker/checkouts/gecko/xpcom/components/nsComponentManager.cpp:1283:17 (libxul.so+0xb94371)
[task 2021-02-12T08:27:22.823Z] 08:27:22     INFO - PID 9655 |     #25 nsComponentManagerImpl::GetServiceByContractID(char const*, nsID const&, void**) /builds/worker/checkouts/gecko/xpcom/components/nsComponentManager.cpp:1472:10 (libxul.so+0xb94ff7)
[task 2021-02-12T08:27:22.823Z] 08:27:22     INFO - PID 9655 |     #26 CallGetService(char const*, nsID const&, void**) /builds/worker/checkouts/gecko/xpcom/components/nsComponentManagerUtils.cpp:61:43 (libxul.so+0xb9789d)
[task 2021-02-12T08:27:22.824Z] 08:27:22     INFO - PID 9655 |     #27 CallGetService<nsIIOService> /builds/worker/workspace/obj-build/dist/include/nsServiceManagerUtils.h:52:10 (libxul.so+0x1be2cf3)
[task 2021-02-12T08:27:22.825Z] 08:27:22     INFO - PID 9655 |     #28 nsScriptSecurityManager::Init() /builds/worker/checkouts/gecko/caps/nsScriptSecurityManager.cpp:1419:17 (libxul.so+0x1be2cf3)
[task 2021-02-12T08:27:22.830Z] 08:27:22     INFO - PID 9655 |     #29 nsScriptSecurityManager::InitStatics() /builds/worker/checkouts/gecko/caps/nsScriptSecurityManager.cpp:1480:28 (libxul.so+0x1be32e1)
[task 2021-02-12T08:27:22.831Z] 08:27:22     INFO - PID 9655 |     #30 nsXPConnect::InitStatics() /builds/worker/checkouts/gecko/js/xpconnect/src/nsXPConnect.cpp:153:3 (libxul.so+0x1aa5cd3)
[task 2021-02-12T08:27:22.832Z] 08:27:22     INFO - PID 9655 |     #31 xpcModuleCtor() /builds/worker/checkouts/gecko/js/xpconnect/src/XPCModule.cpp:11:3 (libxul.so+0x1a79c62)
[task 2021-02-12T08:27:22.833Z] 08:27:22     INFO - PID 9655 |     #32 nsLayoutModuleInitialize() /builds/worker/checkouts/gecko/layout/build/nsLayoutModule.cpp:100:7 (libxul.so+0x53750d7)
[task 2021-02-12T08:27:22.833Z] 08:27:22     INFO - PID 9655 |     #33 nsComponentManagerImpl::Init() /builds/worker/checkouts/gecko/xpcom/components/nsComponentManager.cpp:408:5 (libxul.so+0xb8fc61)
[task 2021-02-12T08:27:22.834Z] 08:27:22     INFO - PID 9655 |     #34 NS_InitXPCOM /builds/worker/checkouts/gecko/xpcom/build/XPCOMInit.cpp:445:51 (libxul.so+0xbf63fa)
[task 2021-02-12T08:27:22.835Z] 08:27:22     INFO - PID 9655 |     #35 XRE_InitEmbedding2(nsIFile*, nsIFile*, nsIDirectoryServiceProvider*) /builds/worker/checkouts/gecko/toolkit/xre/nsEmbedFunctions.cpp:186:8 (libxul.so+0x6818f77)
[task 2021-02-12T08:27:22.836Z] 08:27:22     INFO - PID 9655 |     #36 mozilla::ipc::ScopedXREEmbed::Start() /builds/worker/checkouts/gecko/ipc/glue/ScopedXREEmbed.cpp (libxul.so+0x14bc0c4)
[task 2021-02-12T08:27:22.836Z] 08:27:22     INFO - PID 9655 |     #37 mozilla::dom::ContentProcess::Init(int, char**) /builds/worker/checkouts/gecko/dom/ipc/ContentProcess.cpp:183:13 (libxul.so+0x46e6916)
[task 2021-02-12T08:27:22.837Z] 08:27:22     INFO - PID 9655 |     #38 XRE_InitChildProcess(int, char**, XREChildData const*) /builds/worker/checkouts/gecko/toolkit/xre/nsEmbedFunctions.cpp:699:21 (libxul.so+0x68197b3)
[task 2021-02-12T08:27:22.838Z] 08:27:22     INFO - PID 9655 |     #39 mozilla::BootstrapImpl::XRE_InitChildProcess(int, char**, XREChildData const*) /builds/worker/checkouts/gecko/toolkit/xre/Bootstrap.cpp:67:12 (libxul.so+0x6821702)
[task 2021-02-12T08:27:22.840Z] 08:27:22     INFO - PID 9655 |     #40 content_process_main /builds/worker/checkouts/gecko/browser/app/../../ipc/contentproc/plugin-container.cpp:57:28 (firefox+0xc7901)
[task 2021-02-12T08:27:22.841Z] 08:27:22     INFO - PID 9655 |     #41 main /builds/worker/checkouts/gecko/browser/app/nsBrowserApp.cpp:306:18 (firefox+0xc7901)
[task 2021-02-12T08:27:22.842Z] 08:27:22     INFO - PID 9655 | SUMMARY: ThreadSanitizer: data race /builds/worker/checkouts/gecko/toolkit/components/resistfingerprinting/nsRFPService.cpp:273:7 in RandomMidpoint
[task 2021-02-12T08:27:22.842Z] 08:27:22     INFO - PID 9655 | ==================
[task 2021-02-12T08:27:23.129Z] 08:27:23     INFO - PID 9655 | A content process crashed and MOZ_CRASHREPORTER_SHUTDOWN is set, shutting down
[task 2021-02-12T08:27:23.712Z] 08:27:23     INFO - Setting pref privacy.resistFingerprinting.reduceTimerPrecision.jitter (false)
[task 2021-02-12T08:27:23.786Z] 08:27:23     INFO - .```

Comment 2

[Intermittent Failures Robot]

1 failures in 4322 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform and build breakdown:

• linux1804-64-tsan: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1692444&startday=2021-02-08&endday=2021-02-14&tree=all

Comment 3

[BugBot [:suhaib / :marco]]

https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
For more information, please visit auto_nag documentation.

Comment 4

[Atila Butkovits]

Recent failure log: https://treeherder.mozilla.org/logviewer?job_id=343728802&repo=autoland&lineNumber=12267

Comment 5

[Intermittent Failures Robot]

1 failures in 3115 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform and build breakdown:

• linux1804-64-tsan: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1692444&startday=2021-06-21&endday=2021-06-27&tree=all

Comment 6

[Intermittent Failures Robot]

1 failures in 2224 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 1

Platform and build breakdown:

• linux1804-64-tsan: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1692444&startday=2021-07-12&endday=2021-07-18&tree=all

Comment 7

[Intermittent Failures Robot]

1 failures in 2829 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 1

Platform and build breakdown:

• linux1804-64-tsan-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1692444&startday=2021-08-02&endday=2021-08-08&tree=all

Comment 8

[Intermittent Failures Robot]

1 failures in 2580 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform and build breakdown:

• linux1804-64-tsan-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1692444&startday=2021-08-23&endday=2021-08-29&tree=all

Comment 9

[Byron Campen [:bwc]]

Bumping priority/severity because this shows up in wpt, which in turn causes wpt-sync-bot to pollute the webrtc wpt ini files very badly, which is a big headache for us.

Comment 10

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7ffdb97aad1abd5c7051a5e88f89a87d55dbd91f

Comment 11

[Byron Campen [:bwc]]

Attachment: Bug 1692444: Fix some racy accesses on sSecretMidpointSeed. r?decoder

Comment 12

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=40f90555c4245ce97a7907bb1e8e8dd94c9b70d6

Comment 13

[Intermittent Failures Robot]

1 failures in 3084 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 1

Platform and build breakdown:

• linux1804-64-tsan-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1692444&startday=2021-08-30&endday=2021-09-05&tree=all

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc3e278f1da8
Fix some racy accesses on sSecretMidpointSeed. r=decoder

Comment 15

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/bc3e278f1da8