1692445 - Beta 86 Performance regression when we unset EARLY_BETA_OR_EARLIER

Status: RESOLVED WONTFIX

(Testing :: Performance, defect, P3)

Description

[Florin Strugariu [:Bebe]]

Perfherder has detected a browsertime performance regression from push f74039c739be9b75fbbf739155fedd870ea8d940. As author of one of the patches included in that push, we need your help to address this regression.

Improvements:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
14%	amazon-search	LastVisualChange	android-hw-g5-7-0-arm7-api-16-shippable	cold nocondprof webrender	5,625.13 -> 4,829.08
10%	wikipedia	loadtime	linux64-shippable	cold nocondprof	1,902.71 -> 1,705.96
9%	wikipedia	LastVisualChange	linux64-shippable	cold nocondprof	2,457.14 -> 2,233.33
3%	amazon	LastVisualChange	macosx1014-64-shippable-qr	cold nocondprof webrender	3,273.33 -> 3,166.67

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) will be backed out in accordance with our regression policy.

For more information on performance sheriffing please see our FAQ.

Comment 1

[Florin Strugariu [:Bebe]]

== Change summary for alert #28711 (as of Wed, 10 Feb 2021 18:52:24 GMT) ==

Improvements:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
4%	raptor-tp6-wikipedia-firefox-cold	fcp	windows10-64-shippable	nocondprof	1,416.93 -> 1,362.25

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=28711

Comment 2

[Sean Feng [:sefeng211]]

So we have some regressions mentioned in https://bugzilla.mozilla.org/show_bug.cgi?id=1692213#c2, and since this feature is only enabled in Nightly, these improvements make sense for Beta.

I don't think we need to worry about these improvements since they are expected. ( I need to fix the regression in Nightly)