Closed Bug 1692478 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 27607 - Clear reports in WPT collector when queried.

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox87 fixed)

Status:
RESOLVED FIXED
Milestone:
87 Branch
Tracking Flags:
Tracking Status
firefox87 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 27607 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27607
Details from upstream follow.

b'Ian Clelland <iclelland@chromium.org>' wrote:

Clear reports in WPT collector when queried.

This fixes a bug in the WPT report collector where reports are not
removed from the stash when queried, as they were intended to be.

There was one test in the Network Error Logging suite which relied on
this bug, and tested reports in two passes, which could now fail if all
reports are received before the first query is performed, so this CL
also fixes that test by adding an optional 'retain' query parameter to
the report collector.

Bug: 1177757
Change-Id: I945325f15a2ce633cfa32bcebeedb5be5afaa860

Reviewed-on: https://chromium-review.googlesource.com/2689369
WPT-Export-Revision: 1c891d253a705a68083f27c48a22c468331a5c41

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 68 tests and 1 subtests

Status Summary

Firefox

OK : 53
PASS : 43
FAIL : 31
TIMEOUT: 28
ERROR : 1

Chrome

OK : 64
PASS : 61
FAIL : 24
TIMEOUT: 8

Safari

OK : 37
PASS : 39
FAIL : 17
TIMEOUT: 32
ERROR : 16

Links

GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/content-security-policy/reporting/multiple-report-policies.html
1-Violation report status OK: FAIL
2-Violation report status OK: FAIL
/content-security-policy/reporting/report-same-origin-with-cookies.html
Test report cookies.: FAIL
/content-security-policy/reporting/report-uri-multiple-reversed.html
Violation report status OK.: FAIL
/content-security-policy/reporting/report-uri-multiple.html
Violation report status OK.: FAIL

New Tests That Don't Pass

/content-security-policy/reporting/multiple-report-policies.html
1-Violation report status OK: FAIL (Chrome: PASS, Safari: PASS)
2-Violation report status OK: FAIL (Chrome: PASS, Safari: PASS)
/content-security-policy/reporting/report-multiple-violations-02.html
Test number of sent reports.: FAIL (Chrome: PASS, Safari: FAIL)
/content-security-policy/reporting/report-same-origin-with-cookies.html
Test report cookies.: FAIL (Chrome: PASS, Safari: PASS)
/content-security-policy/reporting/report-uri-effective-directive.html
Violation report status OK.: FAIL (Chrome: PASS, Safari: FAIL)
/content-security-policy/reporting/report-uri-multiple-reversed.html
Violation report status OK.: FAIL (Chrome: PASS, Safari: PASS)
/content-security-policy/reporting/report-uri-multiple.html
Violation report status OK.: FAIL (Chrome: PASS, Safari: PASS)
/network-error-logging/sends-report-on-404.https.html

Test that NEL reports are sent for HTTP errors

: FAIL (Chrome: PASS, Safari: FAIL)
/network-error-logging/sends-report-on-cache-validation.https.html

Test that NEL reports are sent for cache validation requests

: FAIL (Chrome: PASS, Safari: FAIL)
/network-error-logging/sends-report-on-redirect.https.html

Test that NEL reports are sent for redirects

: FAIL (Chrome: PASS, Safari: FAIL)
/network-error-logging/sends-report-on-subdomain-dns-failure.https.html

Test that include_subdomains policies report DNS failures for subdomains

: FAIL (Chrome: PASS, Safari: FAIL)
/network-error-logging/sends-report-on-success-with-subdomain-policy.https.html

Test that NEL reports are sent for successful requests

: FAIL (Chrome: PASS, Safari: FAIL)
/network-error-logging/sends-report-on-success.https.html

Test that NEL reports are sent for successful requests

: FAIL (Chrome: PASS, Safari: FAIL)
/portals/csp/frame-ancestors.sub.html
Violation report status OK.: FAIL (Chrome: FAIL, Safari: FAIL)
/reporting/path-absolute-endpoint.https.sub.html: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
Report is observable to ReportingObserver: TIMEOUT (Chrome: PASS, Safari: FAIL)
Reporting endpoints received reports.: FAIL (Chrome: PASS, Safari: FAIL)
/signed-exchange/reporting/sxg-reporting-navigation-cert_fetch_error-downgraded.tentative.html
SXG reporting test of sxg.failed downgraded from sxg.cert_fetch_error for navigation.: FAIL (Chrome: FAIL)
/signed-exchange/reporting/sxg-reporting-navigation-cert_fetch_error.tentative.html
SXG reporting test of sxg.cert_fetch_error for navigation.: FAIL (Chrome: TIMEOUT)
/signed-exchange/reporting/sxg-reporting-navigation-cert_parse_error-downgraded.tentative.html
SXG reporting test of sxg.failed downgraded from sxg.cert_parse_error for navigation.: FAIL (Chrome: FAIL)
/signed-exchange/reporting/sxg-reporting-navigation-cert_parse_error.tentative.html
SXG reporting test of sxg.cert_parse_error for navigation.: FAIL (Chrome: TIMEOUT)
/signed-exchange/reporting/sxg-reporting-navigation-cert_verification_error-downgraded.tentative.html
SXG reporting test of sxg.failed downgraded from sxg.cert_verification_error for navigation.: FAIL (Chrome: FAIL)
/signed-exchange/reporting/sxg-reporting-navigation-cert_verification_error.tentative.html
SXG reporting test of sxg.cert_verification_error for navigation.: FAIL (Chrome: FAIL)
/signed-exchange/reporting/sxg-reporting-navigation-failed-zero-success-fraction.tentative.html
SXG error report must be downgraded when the cert URL is different from the reporting origin. And succeeded normal NEL report should not be sent when success fraction is zero.: FAIL (Chrome: FAIL)
/signed-exchange/reporting/sxg-reporting-navigation-invalid_integrity_header.tentative.html
SXG reporting test of sxg.invalid_integrity_header for navigation.: FAIL (Chrome: FAIL)
/signed-exchange/reporting/sxg-reporting-navigation-mi_error.tentative.html
SXG reporting test of sxg.mi_error for navigation.: FAIL (Chrome: FAIL)
/signed-exchange/reporting/sxg-reporting-navigation-ok-no-referrer.tentative.html
SXG reporting test of ok for navigation with no-referrer.: FAIL (Chrome: FAIL)
/signed-exchange/reporting/sxg-reporting-navigation-ok-origin-referrer.tentative.html
SXG reporting test of ok for navigation with origin referrer.: FAIL (Chrome: FAIL)
/signed-exchange/reporting/sxg-reporting-navigation-ok.tentative.html
SXG success report must be sent for navigation.: FAIL (Chrome: FAIL)
/signed-exchange/reporting/sxg-reporting-navigation-parse_error.tentative.html
SXG reporting test of sxg.parse_error for navigation.: FAIL (Chrome: PASS)
/signed-exchange/reporting/sxg-reporting-navigation-signature_verification_error-downgraded.tentative.html
SXG reporting test of sxg.failed downgraded from sxg.signature_verification_error for navigation.: FAIL (Chrome: FAIL)
/signed-exchange/reporting/sxg-reporting-navigation-signature_verification_error.tentative.html
SXG reporting test of sxg.signature_verification_error for navigation.: FAIL (Chrome: FAIL)
/signed-exchange/reporting/sxg-reporting-prefetch-cert_fetch_error-downgraded.tentative.html: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
SXG reporting test of sxg.failed downgraded from sxg.cert_fetch_error for prefetch.: TIMEOUT (Chrome: FAIL, Safari: TIMEOUT)
/signed-exchange/reporting/sxg-reporting-prefetch-cert_fetch_error.tentative.html: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
SXG reporting test of sxg.cert_fetch_error for prefetch.: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
/signed-exchange/reporting/sxg-reporting-prefetch-cert_parse_error-downgraded.tentative.html: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
SXG reporting test of sxg.failed downgraded from sxg.cert_parse_error for prefetch.: TIMEOUT (Chrome: FAIL, Safari: TIMEOUT)
/signed-exchange/reporting/sxg-reporting-prefetch-cert_parse_error.tentative.html: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
SXG reporting test of sxg.cert_parse_error for prefetch.: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
/signed-exchange/reporting/sxg-reporting-prefetch-cert_verification_error-downgraded.tentative.html: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
SXG reporting test of sxg.failed downgraded from sxg.cert_verification_error for prefetch.: TIMEOUT (Chrome: FAIL, Safari: TIMEOUT)
/signed-exchange/reporting/sxg-reporting-prefetch-cert_verification_error.tentative.html: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
SXG reporting test of sxg.cert_verification_error for prefetch.: TIMEOUT (Chrome: FAIL, Safari: TIMEOUT)
/signed-exchange/reporting/sxg-reporting-prefetch-failed-zero-success-feaction.tentative.html
SXG error report must be downgraded when the cert URL is different from the reporting origin. And succeeded normal NEL report should not be sent when success fraction is zero.: FAIL (Chrome: FAIL, Safari: FAIL)
/signed-exchange/reporting/sxg-reporting-prefetch-invalid_integrity_header.tentative.html: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
SXG reporting test of sxg.invalid_integrity_header for prefetch.: TIMEOUT (Chrome: FAIL, Safari: TIMEOUT)
/signed-exchange/reporting/sxg-reporting-prefetch-mi_error.tentative.html: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
SXG reporting test of sxg.mi_error for prefetch.: TIMEOUT (Chrome: FAIL, Safari: TIMEOUT)
/signed-exchange/reporting/sxg-reporting-prefetch-ok.tentative.html: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
SXG success report must be sent for prefetching.: TIMEOUT (Chrome: FAIL, Safari: TIMEOUT)
/signed-exchange/reporting/sxg-reporting-prefetch-parse_error.tentative.html: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
SXG reporting test of sxg.parse_error for prefetch.: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
/signed-exchange/reporting/sxg-reporting-prefetch-signature_verification_error-downgraded.tentative.html: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
SXG reporting test of sxg.failed downgraded from sxg.signature_verification_error for prefetch.: TIMEOUT (Chrome: FAIL, Safari: TIMEOUT)
/signed-exchange/reporting/sxg-reporting-prefetch-signature_verification_error.tentative.html: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
SXG reporting test of sxg.signature_verification_error for prefetch.: TIMEOUT (Chrome: FAIL, Safari: TIMEOUT)
/signed-exchange/subresource/sxg-subresource-header-integrity-mismatch.tentative.html: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
Subresource signed exchange prefetch.: TIMEOUT (Chrome: FAIL, Safari: TIMEOUT)
/trusted-types/trusted-types-reporting-check-report.html: ERROR (Chrome: OK, Safari: ERROR)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a691ff3142c0
[wpt PR 27607] - Clear reports in WPT collector when queried., a=testonly

https://hg.mozilla.org/mozilla-central/rev/a691ff3142c0

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox87: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in before you can comment on or make changes to this bug.