1692481 - The “Import Error” error modal is not displayed on the “about:logins” page after importing logins from a CSV file that contains multiple column headers

Status: VERIFIED FIXED

(Firefox :: about:logins, defect)

Description

[Simona Rosu [:srosu], Ecosystem QA]

Attachment: WronglyLoginsAdded.gif

[Affected versions]:

• Firefox Nightly 87.0a1 (Build ID:20210212100155)

[Affected Platforms]:

• macOS 11.1
• Windows 10 x64
• Ubuntu 20.04 x64.

[Prerequisites]:

• Have a new Firefox profile.
• Have a CSV file that contains multiple username/password column headers saved on your computer.

[Steps to reproduce]:

1. Open the Firefox browser with the profile from prerequisites.
2. Navigate to the "about:logins" page.
3. Click on the Ellipsis Menu and select the “Import from a File…” option.
4. Select the CSV file from prerequisites and click on the “Open” button.
5. Observe what happens next.

[Expected result]:

• The logins from the CSV file are not imported and the “Import Error” modal is displayed.

[Actual result]:

• All of the logins are imported on the “about:logins” page and the “Import Complete” modal is displayed.

[Notes]:

• All these logins are recognized as normal in the “Import Complete” modal and are imported with the last username/password updated on the CSV file.
• Attached a screen recording of the issue.

Comment 1

[Andrei Petcu]

Attachment: Bug 1692481 Fix Import Error error modal after importing with multiple column headers

Comment 2

[Andrei Petcu]

I fixed the bug and pushed a patch for review but testing this I noticed that the text does not make sens.

Multiple Conflicting Values for One Login
For example: multiple usernames, passwords, URLs, etc. for one login.

I think it should be:

Multiple Conflicting Values
For example: multiple usernames, passwords, URLs, etc.

What do you think Sam? This text was initially decided when we thought we were able to detect multiple usernames per row but that turns out to be impossible. We can only detect multiple "username" columns per file. The columns are the same for all the rows.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/03d06ec83c6a
Fix Import Error error modal after importing with multiple column headers r=tgiles

Comment 4

[Sam Foster [:sfoster] (he/him)]

(In reply to petcuandrei from comment #2)

I fixed the bug and pushed a patch for review but testing this I noticed that the text does not make sens.

What do you think Sam? This text was initially decided when we thought we were able to detect multiple usernames per row but that turns out to be impossible. We can only detect multiple "username" columns per file. The columns are the same for all the rows.

I think this is fine as-is for now. Lets see if this comes up in the wild and we can follow up as necessary then.

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/03d06ec83c6a

Comment 6

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue using the latest Firefox Nightly 87.0a1 (Build ID: 20210217094559) on Windows 10 x64, Ubuntu 20.04 and macOS 11.1.

• The “Import Error” modal is displayed after trying to import logins from a CSV file that contains multiple column headers.