Closed Bug 1692507 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 27610 - Fix expectations of a recently committed test

Categories

(Core :: Layout: Flexbox, task, P4)

task

Tracking

()

RESOLVED FIXED
87 Branch
Tracking Status
firefox87 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 27610 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27610
Details from upstream follow.

b'Sergio Villar Senin <svillar@igalia.com>' wrote:

Fix expectations of a recently committed test

In PR 27520 we landed a new test for buttons with children with percentage heights called percentage-descendant-of-anonymous-flex-item.html

In the review process the height: 100% was replaced by height: 100px. However that was a bad decision because every UA styles buttons in a different way (even the same UA in different platforms) meaning that due to margins and paddings that height could be smaller than 100px. Switching back to the percentage height in the expectations.

Component: web-platform-tests → Layout: Flexbox
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d58340cf7a2a
[wpt PR 27610] - Fix expectations of a recently committed test, a=testonly
https://hg.mozilla.org/integration/autoland/rev/53deff12056f
[wpt PR 27610] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in before you can comment on or make changes to this bug.