1692527 - Non-sponsored Quick Suggest results should show "Firefox Suggests" instead of "Sponsored"

Status: VERIFIED FIXED

(Firefox :: Address Bar, task, P1)

Description

[Drew Willcoxon :adw]

The Quick Suggest UX spec calls for non-sponsored results to show "Firefox Suggests" instead of "Sponsored" like they currently do (see spec in bug 1692518). Right now the only non-sponsored results are Wikipedia URLs.

This will require distinguishing between sponsored vs. non-sponsored URLs in the result payload and then updating the view to show the right thing.

Comment 1

[Drew Willcoxon :adw]

I haven't started working on this yet and plan to work on other things first.

Comment 3

[Drew Willcoxon :adw]

[Tracking Requested - why for this release]:

We need this for the contextual services/quick suggest experiment in 87.

Comment 4

[Drew Willcoxon :adw]

Attachment: Bug 1692527 - Show "Firefox Suggests" instead of "Sponsored" for non-sponsored quick suggest results.

Depends on D106490

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/integration/autoland/rev/3db22d85281c013477aee074b94c98a3010d1822
https://hg.mozilla.org/mozilla-central/rev/3db22d85281c

Comment 6

[Drew Willcoxon :adw]

Comment on attachment 9205581 [details]
Bug 1692527 - Show "Firefox Suggests" instead of "Sponsored" for non-sponsored quick suggest results.

Beta/Release Uplift Approval Request

• User impact if declined: We need this for the contextual services/quick suggest experiment in 87.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Type something in the urlbar that triggers a non-sponsored (Firefox Suggests) quick suggest result -- e.g.., "wiki" should trigger Wikipedia

The result row should have "Firefox Suggests" at the end instead of "Sponsored".

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small change that only affects the quick suggest feature, which is preffed off by default. Comes with a test.
• String changes made/needed:

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9205581 [details]
Bug 1692527 - Show "Firefox Suggests" instead of "Sponsored" for non-sponsored quick suggest results.

Approved for 87.0b4.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/008923c64d60

Comment 9

[Cristian Baica [:cbaica], Release Desktop QA]

Tested the issue using Fx 88.0a1 and Fx87.0b4 on Windows 10, Ubuntu 18.04 and macOS 10.15. When typing 'wiki' the 'Sponsored' text is no longer displayed. The displayed text for non-sponsored URLs is now 'Firefox Suggests'.