Closed Bug 1692571 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 27615 - Let OverflowClip instead of ScrollTranslation create layout shift root

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox87 fixed)

Status:
RESOLVED FIXED
Milestone:
87 Branch
Tracking Flags:
Tracking Status
firefox87 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 27615 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27615
Details from upstream follow.

b'Xianzhu Wang <wangxianzhu@chromium.org>' wrote:

Let OverflowClip instead of ScrollTranslation create layout shift root

This avoids layout shift root status change (causing layout shifts in
descendants ignored) when the existence of ScrollTranslation changes,
e.g. when overflowing status changes or scroll offset changes from 0 to
non-zero.

Summary of layout_shift.cluster_telemetry
https://ct.skia.org/results/cluster-telemetry/tasks/chromium_perf_runs/wangxianzhu-ChromiumPerf-5625/html/index.html:
mainFrameCumulativeLayoutShift 1.441%
overallCumulativeLayoutShift 0.519%

Bug: 1165353
Change-Id: I61cb5994e9d70c751a2767de417b8e70aab79def
Reviewed-on: https://chromium-review.googlesource.com/2690998
WPT-Export-Revision: d49dfad1dd123b3d4fe9f5de6700be8aed9ea952

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
FAIL : 1

Chrome

TIMEOUT: 2

Safari

OK : 1
FAIL : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/layout-instability/shift-with-overflow-status-change.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: TIMEOUT, Safari: OK)
Change under overflow clipping container causing shift and overflow status change at the same time: FAIL (Chrome: TIMEOUT, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

/layout-instability/shift-with-overflow-status-change.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: TIMEOUT, Safari: OK)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a300f14f6470
[wpt PR 27615] - Let OverflowClip instead of ScrollTranslation create layout shift root, a=testonly

https://hg.mozilla.org/mozilla-central/rev/a300f14f6470

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox87: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in before you can comment on or make changes to this bug.