Closed Bug 1692619 Opened 8 months ago Closed 1 month ago

Only list pinned comments under all comments where posted

Categories

(Webtools Graveyard :: Pontoon, defect, P2)

Tracking

(Not tracked)

RESOLVED MOVED

People

(Reporter: mathjazz, Unassigned)

Details

Attachments

(2 files)

Attached image Screenshot

We list pinned comments in the Pinned comments and All comments sections. That works fine in the translate view of the locale the pinned comment has been posted in, but not in translate views of other locales.

See screenshot for details.

(In reply to Matjaz Horvat [:mathjazz] from comment #0)

That works fine in the translate view of the locale the pinned comment has been posted in, but not in translate views of other locales.

Did you mean it the other way around? It looks weird in the locale where the original discussion was, because it's duplicated.

I normally rewrite the comment with the explicit purpose of pinning, so it makes sense as stand-alone. This one was temporary and the string was already translated by all locales, so I didn't bother.

Attached image comments.png

On the other hand, I'm very confused that the pinned comment shows up twice in a locale.

Original discussion in zh-TW on the left, how the comment shows up in German on the right.

(In reply to Francesco Lodolo [:flod] from comment #1)

(In reply to Matjaz Horvat [:mathjazz] from comment #0)

That works fine in the translate view of the locale the pinned comment has been posted in, but not in translate views of other locales.

Did you mean it the other way around? It looks weird in the locale where the original discussion was, because it's duplicated.

Actually I meant it the way I wrote it. :) Why do you think duplicating the comment wouldn't be confusing on the translate views of other locales?

The idea behind duplicating the comments in both sections was that it allows you to see the important (pinned) comments first, and then check how the conversation evolved in chronological order under the All comments section of the locale where the original discussion took place. Moving the pinned comments out of that section (as opposed to copying) makes the discussion harder to follow and confusing.

I normally rewrite the comment with the explicit purpose of pinning, so it makes sense as stand-alone. This one was temporary and the string was already translated by all locales, so I didn't bother.

Interesting. I haven't seen pinned comments being used that way outside the example you gave, but I understand the motivation. If you plan to use pinned comments like this, then it obviously makes no sense to repeat them.

Also, based on the data we now have (7 pinned comments :-)), it doesn't seem like we'll be having a lot of discussions after the comment gets pinned, which would indeed be less confusing if the pinned comment was repeated.

I suppose you wouldn't mind dropping the section titles (Pinned comments, All comments) as part of changing the behavior of pinned comments?

Flags: needinfo?(francesco.lodolo)

Interesting. I haven't seen pinned comments being used that way outside the example you gave, but I understand the motivation. If you plan to use pinned comments like this, then it obviously makes no sense to repeat them.

Also, based on the data we now have (7 pinned comments :-)), it doesn't seem like we'll be having a lot of discussions after the comment gets pinned, which would indeed be less confusing if the pinned comment was repeated.

Out of curiosity, am I the only one who's been using them or there's someone else?

The other reason I write a specific comment to be pinned, is that most people will read it from the RESOURCES section, below the original string, not from the comments tab.

I suppose you wouldn't mind dropping the section titles (Pinned comments, All comments) as part of changing the behavior of pinned comments?

I don't mind dropping them. But, if we do, we probably need to differentiate the pinned comment a bit more (different background?), and definitely keep a separator.

Flags: needinfo?(francesco.lodolo)
*This bug has been moved to GitHub.*

*Please check it out on https://github.com/mozilla/pontoon/issues.*
Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → MOVED
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.