Closed Bug 1692633 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 27618 - [webcodecs] Clone VideoFrame when serializing

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox88 fixed)

Status:
RESOLVED FIXED
Milestone:
88 Branch
Tracking Flags:
Tracking Status
firefox88 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 27618 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27618
Details from upstream follow.

b'Dan Sanders <sandersd@chromium.org>' wrote:

[webcodecs] Clone VideoFrame when serializing

This changes the serialization semantics of VideoFrame so that the
lifetimes of the serialized (source) frame and deserialized (recieved)
frames are separate. The source and recieved frames must both be closed.

In the case that there are multiple receivers (eg. BroadcastChannel),
they still share a single handle, and only one of them should be closed.
This is necessary to ensure that no dangling references remain that
would require waiting for GC to destroy the underlying frames.

Bug: 1178038
Change-Id: I2199246b9d7caf9fd317b3c1dc8ae310ced9662d
Reviewed-on: https://chromium-review.googlesource.com/2694166
WPT-Export-Revision: 349e4b0a1ad9b1ac001d47ea47ea54313605a1e9

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 5 subtests

Status Summary

Firefox

OK : 2
FAIL: 10

Chrome

OK : 2
PASS: 8
FAIL: 2

Safari

OK : 2
FAIL: 10

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/webcodecs/video-frame-serialization.any.worker.html
Test we can clone a VideoFrame.: FAIL (Chrome: PASS, Safari: FAIL)
Verify closing a frame doesn't affect its clones.: FAIL (Chrome: PASS, Safari: FAIL)
Verify cloning a closed frame throws.: FAIL (Chrome: PASS, Safari: FAIL)
Verify closing frames does not propagate accross contexts.: FAIL (Chrome: FAIL, Safari: FAIL)
Verify posting closed frames throws.: FAIL (Chrome: PASS, Safari: FAIL)
/webcodecs/video-frame-serialization.any.html
Test we can clone a VideoFrame.: FAIL (Chrome: PASS, Safari: FAIL)
Verify closing a frame doesn't affect its clones.: FAIL (Chrome: PASS, Safari: FAIL)
Verify cloning a closed frame throws.: FAIL (Chrome: PASS, Safari: FAIL)
Verify closing frames does not propagate accross contexts.: FAIL (Chrome: FAIL, Safari: FAIL)
Verify posting closed frames throws.: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ae095af48a0e
[wpt PR 27618] - [webcodecs] Clone VideoFrame when serializing, a=testonly
https://hg.mozilla.org/integration/autoland/rev/c8bfcd9b1392
[wpt PR 27618] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/ae095af48a0e
https://hg.mozilla.org/mozilla-central/rev/c8bfcd9b1392

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox88: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in before you can comment on or make changes to this bug.