1692919 - Replace nsIArray/nsIMutableArray with Array<T> in Thunderbird code

Status: ASSIGNED

(MailNews Core :: General, task)

Description

[Ben Campbell]

Bug 1583030 removed nsIArray use from the xpidl interfaces, but there are still a few internal uses we could ditch. So this is a catch-all bug for that.

Comment 1

[Ben Campbell]

Attachment: 1692919-kill-MsgGetHeadersFromKeys2-1.patch

Tidy up some cruft left over from Bug 1583030.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ad9236284ff6
Remove leftover MsgGetHeadersFromKeys2() helper (added for Bug 1583030). r=mkmelin

Comment 3

[Ben Campbell]

Attachment: Bug 1692919 - Reduce nsMsgKey lookups in nsMsgDatabase::ApplyRetentionSettings(). r?mkmelin

Also strips out nsIMutableArray use in nsMsgDatabase.

Comment 4

[Ben Campbell]

Attachment: Bug 1692919 - Remove leftover nsIArray helper BuildIdsAndKeyArray2() in nsImapMailFolder. r?mkmelin

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0710e3773fc4
Reduce nsMsgKey lookups in nsMsgDatabase::ApplyRetentionSettings(). r=mkmelin
https://hg.mozilla.org/comm-central/rev/3e726d4ed730
Remove leftover nsIArray helper BuildIdsAndKeyArray2() in nsImapMailFolder. r=mkmelin

Comment 6

[Ben Campbell]

Attachment: Bug 1692919 - Remove a bunch of obsolete nsIArray-related includes. r?mkmelin

Depends on D114315

Comment 7

[Ben Campbell]

(In reply to Ben Campbell from comment #6)

Created attachment 9220282 [details]
Bug 1692919 - Remove a bunch of obsolete nsIArray-related includes. r?mkmelin

Depends on D114315

That's a complete lie ;-) It's a stand-alone patch, I just didn't realise that phab assumed that stacked-up changesets were dependent upon each other. Not an unreasonable assumption, so I'll be more careful in future!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6b6e447856af
Remove a bunch of obsolete nsIArray-related includes. r=mkmelin

Comment 9

[Ben Campbell]

Attachment: Bug 1692919 - Remove nsIMutableArray use in nsMsgDBView. r?mkmelin

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/04b86501fca6
Remove nsIMutableArray use in nsMsgDBView. r=mkmelin

Comment 11

[Ben Campbell]

Attachment: Bug 1692919 - Remove obsolete MsgHdrsToTArray() from nsMsgUtils. r?mkmelin

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e1d8b83f18f0
Remove obsolete MsgHdrsToTArray() from nsMsgUtils. r=mkmelin

Comment 13

[Ben Campbell]

Attachment: Bug 1692919 - Tidy away some leftover nsIMutableArray cruft. r=mkmelin

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2edb175ab6ea
Tidy away some leftover nsIMutableArray cruft. r=mkmelin

Comment 15

[Geoff Lankow (:darktrojan)]

Can we close this now?

Comment 16

[Ben Campbell]

No... there are still a few tricky ones to remove:

• There are a bunch which are params to nsIWindowWatcher.openWindow(), and I don't think there's a non-nsIArray alternative. So those probably stay as they are.
• nsAbOutlookDirectory, nsAbOSXDirectory and nsAbDirProperty use nsIMutableArray to deal with awkwardness in dealing with cards and mailinglists. Not sure what's involved here.
• nsMsgCompUtils.cpp uses nsIArray to handle heterogeneous list of embedded objects. Don't know what to do with this one. Other than sitting down to go through the message composition code line by line to understand it properly :-)