1692961 - Always set BCTargetActor isTopLevelTarget via a constructor option

Status: RESOLVED FIXED

(DevTools :: Framework, task, P3)

Description

[Julian Descottes [:jdescottes]]

With the initial implementation in Bug 1690698, some BrowsingContextTargetActor classes (eg webextension & parent process) automatically pass isTopLevelTarget: true when calling BrowsingContextTargetActor::initialize. While this is ok for now, in the future we might want to spawn webextension targets within a parent process debugging session and such a target should not be flagged as top level.

Therefore we should always pass isTopLevelTarget as an explicit constructor argument.

Also, it could be an occasion to settle on a consistent constructor signature:

BrowsingContextTargetActor(conn, options)

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1692961 - [devtools] Explicitly pass isTopLevelTarget as an option to all BrowsingContextTargetActor

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/20f12466d1f2
[devtools] Explicitly pass isTopLevelTarget as an option to all BrowsingContextTargetActor r=ochameau

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/20f12466d1f2