Closed
Bug 1693048
Opened 4 years ago
Closed 4 years ago
Update close tabs (and quit/exit) warning dialog content for proton
Categories
(Firefox :: Tabbed Browser, enhancement, P2)
Tracking
()
VERIFIED
FIXED
88 Branch
People
(Reporter: Gijs, Assigned: mathjazz)
References
(Blocks 1 open bug)
Details
(Keywords: helpwanted, Whiteboard: [proton-modals])
Attachments
(1 file)
To do:
- update the accept button text to use sentence case ("Close tabs")
- update the body text to drop variations of "Are you sure you want to continue?"
- update the checkbox text to address the user as "you" - "Warn you when closing multiple tabs"
- switch the order of the title around ("Close tabs and quit/exit?" rather than "Quit/exit and close tabs?")
Reporter | ||
Updated•4 years ago
|
Blocks: proton-modals
Updated•4 years ago
|
See Also: → https://jira.mozilla.com/browse/FIDEFE-203
Reporter | ||
Updated•4 years ago
|
Keywords: helpwanted
Comment 1•4 years ago
|
||
For the record, it looks like the current strings are approximately here:
https://searchfox.org/mozilla-central/rev/26330a08b1f9d06938faa0aa5e0f8c7a58064aa2/browser/locales/en-US/chrome/browser/tabbrowser.properties#10-30
Assignee | ||
Updated•4 years ago
|
Assignee: nobody → m
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•4 years ago
|
||
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/e31b84669428
Update close tabs warning dialog. r=Gijs
Comment 5•4 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox88:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
Updated•4 years ago
|
Comment 6•3 years ago
|
||
Verified in latest nightly build 90.0a1 (2021-05-13) (64-bit) and beta build 89.0b11 (64-bit)
The spec changed , "Warn you when closing multiple tabs" should now say "warn when closing multiple tabs" , and it's shown as expected.
Updating flags accordingly.
Best regards,
Clara
Updated•3 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•