Closed
Bug 1693101
Opened 3 years ago
Closed 3 years ago
Only include profiler headers when needed in code generated by Codegen.py
Categories
(Core :: DOM: Bindings (WebIDL), enhancement)
Core
DOM: Bindings (WebIDL)
Tracking
()
RESOLVED
FIXED
88 Branch
| Tracking | Status | |
|---|---|---|
| firefox88 | --- | fixed |
People
(Reporter: florian, Assigned: florian)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Currently GeckoProfiler.h is included unconditionally by bindings generated by Codegen.py:
# XXX Not sure when we actually need this
bindingHeaders["GeckoProfiler.h"] = True
but the generated code only uses the AUTO_PROFILER_LABEL_DYNAMIC_FAST macro, defined in the smaller ProfilerLabels.h header created in bug 1691589.
|
Assignee | |
Comment 1•3 years ago
|
||
|
||
Updated•3 years ago
|
Attachment #9203470 -
Attachment description: Bug 1693101 - Codegen.py should only include ProfilerLabels.h when a profiler label will be generated, → Bug 1693101 - Codegen.py should only include ProfilerLabels.h when a profiler label will be generated, r=sg
Pushed by fqueze@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bcd5eeee60ce Codegen.py should only include ProfilerLabels.h when a profiler label will be generated, r=sg,peterv
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox88:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•