1693120 - onLocationChange handler "consumers" in browser.js / tabbrowser.js should not update internal state for subframe loads

Status: NEW

(Firefox :: Tabbed Browser, defect)

Description

[:Gijs (he/him)]

Unfortunately there are a number of places in our onLocationChange handlers not guarded by an isTopLevel check, e.g. https://searchfox.org/mozilla-central/rev/5120ec68572d946bd15101cf2ee2eaf4a210724f/browser/base/content/browser.js#5222 , https://searchfox.org/mozilla-central/rev/5120ec68572d946bd15101cf2ee2eaf4a210724f/browser/base/content/browser.js#5241-5251 , that really should be.

This means some of those features probably don't work properly on pages with subframes, and/or where they do, it's by accident.

We should audit for this and fix it.