1693196 - Remove code for non-existent fullscreen button

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Markus Stange [:mstange]]

From macOS 10.7 to 10.9, there was a full screen button in the top right corner of the window.
Starting with 10.10, this button is no longer a separate button; it was merged into the green "zoom" button.

We only support 10.12+, so we can remove code that was trying to center the fullscreen button vertically in the tab bar.

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1693196 - Remove code for setting the full screen button's position. Starting with macOS 10.10, there is no full screen button anymore. r=#mac-reviewers

Comment 2

[Markus Stange [:mstange]]

Attachment: Bug 1693196 - Remove use of -moz-default-appearance: -moz-mac-fullscreen-button.

This element is always 0x0 and macOS widget code no longer needs to know its position.

Depends on D105378

Comment 3

[Markus Stange [:mstange]]

Attachment: Bug 1693196 - Remove -moz-mac-fullscreen-button value. r=emilio

Depends on D105379

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cc17bc31a12b
Remove code for setting the full screen button's position. Starting with macOS 10.10, there is no full screen button anymore. r=mac-reviewers,bradwerth
https://hg.mozilla.org/integration/autoland/rev/685f8ec93eda
Remove use of -moz-default-appearance: -moz-mac-fullscreen-button. r=emilio
https://hg.mozilla.org/integration/autoland/rev/34a40ec97ea3
Remove -moz-mac-fullscreen-button value. r=emilio

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/cc17bc31a12b
https://hg.mozilla.org/mozilla-central/rev/685f8ec93eda
https://hg.mozilla.org/mozilla-central/rev/34a40ec97ea3