Closed Bug 1693313 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 27658 - Portals: Deflake autofocus tests

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox88 fixed)

RESOLVED FIXED
88 Branch
Tracking Status
firefox88 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 27658 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27658
Details from upstream follow.

b'Adithya Srinivasan <adithyas@chromium.org>' wrote:

Portals: Deflake autofocus tests

Autofocused elements are not guaranteed to be focused on load, flushing
autofocus candidates for a document is part of the rendering update
(see 11.5 in [1]). This CL updates tests to call requestAnimationFrame
after the document loads to ensure Document::FlushAutofocusCandidates()
[2] gets a chance to run.

[1] https://html.spec.whatwg.org/multipage/webappapis.html#update-the-rendering
[2] https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/core/dom/document.cc;l=7770;drc=15d361f31e050e55eb6b2ada1a02ea5b26eb4f70

Bug: 1178492
Change-Id: Iedc6758c47e2cff53a3bca499aa55e13437fe6ee

Reviewed-on: https://chromium-review.googlesource.com/2699127
WPT-Export-Revision: 4b9a2510363faa0248faedd5662a692dcbaea810

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 10 subtests

Status Summary

Firefox

OK : 1
FAIL: 10

Chrome

OK : 1
FAIL: 10

Safari

OK : 1
FAIL: 10

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/portals/portals-focus.sub.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
test that an element inside a portal cannot steal focus: FAIL (Chrome: FAIL, Safari: FAIL)
test that activeElement inside a portal is updated after focus() is called: FAIL (Chrome: FAIL, Safari: FAIL)
test that an element inside a portal's x-origin subframe cannot steal focus: FAIL (Chrome: FAIL, Safari: FAIL)
test that a portal's x-origin subframe becomes active element on focus: FAIL (Chrome: FAIL, Safari: FAIL)
test that an element inside an adopted portal cannot steal focus: FAIL (Chrome: FAIL, Safari: FAIL)
test that a x-origin iframe inside an adopted portal cannot steal focus: FAIL (Chrome: FAIL, Safari: FAIL)
test that autofocus inside a portal works: FAIL (Chrome: FAIL, Safari: FAIL)
test that a portal is keyboard focusable: FAIL (Chrome: FAIL, Safari: FAIL)
test that we cannot tab into a portal's contents: FAIL (Chrome: FAIL, Safari: FAIL)
test that a portal is keyboard activatable: FAIL (Chrome: FAIL, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

/portals/portals-focus.sub.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/402bc52451cc
[wpt PR 27658] - Portals: Deflake autofocus tests, a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/298acd34277f
[wpt PR 27658] - Portals: Deflake autofocus tests, a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/591b1205bdd5
[wpt PR 27658] - Portals: Deflake autofocus tests, a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in before you can comment on or make changes to this bug.