1693434 - Report uncaught Objective C exceptions via crash reports

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, task, P1)

Description

[Markus Stange [:mstange]]

If something triggers an Objective C exception that isn't caught by one of our exception guards, we never hear about it.
We should install catch-all handlers for uncaught exceptions, and crash in them, so that we can see those exceptions in crash reports.

Such exceptions are unexpected. They might get us into an inconsistent state, where some things continue to operate normally and others are strangely broken. Just as an example, if -[ChildView pasteboard:item:provideDataForType:] throws an exception, drag and drop is broken for the rest of the browsing session.

Crashing eagerly is a safer default. It might lead to increased amounts of crashing, but at least we will know about these occurrences and can address them properly.

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1693434 - Report uncaught Objective C exceptions. r=spohl

NSSetUncaughtExceptionHandler installs a handler which is called just before we
would crash anyway, I think. So this handler lets us collect information about
exceptions that are not even caught by the native event loop.

Comment 2

[Markus Stange [:mstange]]

Attachment: Bug 1693434 - Crash when an Objective C exception bubbles up into the native event loop. r=spohl

Depends on D105561

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/084675db1f00
Report uncaught Objective C exceptions. r=spohl
https://hg.mozilla.org/integration/autoland/rev/cb05c7bcf9bf
Crash when an Objective C exception bubbles up into the native event loop. r=spohl

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/084675db1f00
https://hg.mozilla.org/mozilla-central/rev/cb05c7bcf9bf