1693501 - Address book column header borders disappear on every second navigation in directory pane

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Thomas D. (:thomas8)]

Attachment: Screencast (mp4): AB column header borders disappear for every second dir pane selection

STR

1. Might be related to switching themes, try Dark theme
2. Observe AB column headers while navigating in directory pane (cursor-down or mouse)

Actual result (see screencast)

• every second selection in dir pane makes the AB column header borders disappear

Expected result

• AB column header borders should not change with dir pane selection

Comment 1

[Richard Marti (:Paenglab)]

Very strange, something sets on every even #dirTree row on every <treecol> element directly a border-color: transparent;. I don't know from where this comes. It's not from CSS as it is directly set on the elements and I see this behaviour only in AB.

Comment 2

[Richard Marti (:Paenglab)]

I found the regression: bug 1633620 https://searchfox.org/comm-central/rev/a6dc672427f82bcb190b2ed13e8f72ea249f4b78/mailnews/addrbook/content/abResultsPane.js#367-372

Comment 3

[Geoff Lankow (:darktrojan)]

That always was a hack, and it's more obvious than I realised. Take it away, I don't care for it any more.

Comment 4

[Richard Marti (:Paenglab)]

Attachment: 1693501-remove-AB-treecol-bordercolor.patch

I removed the part that forces the border-color on treeheaders.

Comment 5

[Geoff Lankow (:darktrojan)]

Comment on attachment 9204152 [details] [diff] [review]
1693501-remove-AB-treecol-bordercolor.patch

Thanks Richard.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8de7737647e7
Remove a hack that interferes with themed treeheaders in AB. r=darktrojan

Comment 7

[Richard Marti (:Paenglab)]

Comment on attachment 9204152 [details] [diff] [review]
1693501-remove-AB-treecol-bordercolor.patch

[Approval Request Comment]
Regression caused by (bug #): Bug 1633620
User impact if declined: inconsistent AB treeheader display with themes enabled
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9204152 [details] [diff] [review]
1693501-remove-AB-treecol-bordercolor.patch

[Triage Comment]
this made it into 87, no beta uplift needed

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9204152 [details] [diff] [review]
1693501-remove-AB-treecol-bordercolor.patch

[Triage Comment]
Approved for esr78

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 78.8.1:
https://hg.mozilla.org/releases/comm-esr78/rev/2a8c7ab73984