Closed Bug 1693620 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 27684 - Avoid DCHECK in HTMLSelectElement::SetOption

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
88 Branch
Tracking Flags:
Tracking Status
firefox88 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 27684 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27684
Details from upstream follow.

b'Joey Arhar <jarhar@chromium.org>' wrote:

Avoid DCHECK in HTMLSelectElement::SetOption

SetOption adds a new \<option>, but in some unusual cases, the \<option>
can be a parent of the \<select> which it is getting added to, which
prevents the \<option> from being appended to the \<select>. This adds a
check to the ExceptionState which reflects the failure to append instead
of continuing on assuming that the \<option> was successfully appended.

Fixed: 1178128
Change-Id: Ibfc04c2d4eb672fa2d7695855ffd8ca3d773337b
Reviewed-on: https://chromium-review.googlesource.com/2704645
WPT-Export-Revision: 46e491fe5cccc919e96296042dde70d5de51a5be

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 14 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/813e71782937
[wpt PR 27684] - Avoid DCHECK in HTMLSelectElement::SetOption, a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3f9473ba2c19
[wpt PR 27684] - Avoid DCHECK in HTMLSelectElement::SetOption, a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/32946273f679
[wpt PR 27684] - Avoid DCHECK in HTMLSelectElement::SetOption, a=testonly

https://hg.mozilla.org/mozilla-central/rev/32946273f679

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox88: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in before you can comment on or make changes to this bug.