1693688 - radiosize.xhtml and checkboxsize.xhtml reftests fail on macOS with non-native theme enabled

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Stephen A Pohl [:spohl]]

Emilio, I'm probably just missing something obvious here, but I can't seem to wrap my head around these two test failures here:

Reftest analyzer

I'm sure it has to do with our new minimum size for radio buttons and checkboxes, but I have been unable to tweak the test locally because it simply refuses to show any checkboxes or radio buttons when I run the reftest locally... Rather than kicking off a series of try runs to test potential fixes I thought it might make sense to ask you if you are able to spot an obvious fix here. Thank you!

Comment 1

[Markus Stange [:mstange]]

This reftest uses XUL, which cannot be used by regular web content. That's why it's loaded with the chrome://reftest/content/osx-theme/radiosize.xhtml URL. I'm not sure what the easiest way to run it in a normal browser (outside reftests) is.

Comment 2

[Stephen A Pohl [:spohl]]

Right, what I meant to say is: when I run this as a reftest locally, the data URLs that are logged as snapshots of the page are usually just a blank page, which means that I can't really compare expected vs. actual snapshots to tweak any potential fix...

Comment 3

[Markus Stange [:mstange]]

Oh, weird, I don't know why that is.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

FWIW I'm not too concerned about failing tests in toolkit/themes/osx. But sure, can poke.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1693688 - Make the non-native theme not return minimum sizes for checkboxes (and most other widgets). r=spohl,mstange

This matches closer what Chrome and Safari do (Safari paints outside of
the box when this happens, but the layout box still respects the
author), see:

data:text/html,<button style="padding: 0; width: 0">
data:text/html,<input type=checkbox style="width: 0">

Etc. For checkboxes, this matches what OSX does, too.

Since we still want checkboxes to be slightly larger than what they'd be
otherwise, we add a hook to tweak it when non-native theme is enabled.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e0b1f4b79d4b
Make the non-native theme not return minimum sizes for checkboxes (and most other widgets). r=spohl,mstange

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d0bd198837ee
Remove unnecessarily hard-coded checkbox size that we now honor from a test.

Comment 8

[Noemi Erli[:noemi_erli]]

Backed out 2 changesets (Bug 1693688) for causing failures in browser_options-view-01.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=d15y9PLlSoOq_aNH2dyz2Q.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&searchStr=linux%2C18.04%2Cx64%2Cdebug%2Cmochitests%2Ctest-linux1804-64%2Fdebug-mochitest-devtools-chrome-e10s%2Cdt3&revision=e0b1f4b79d4b9bb1633283ef4f9f9e9dc6c0fe7e

Range: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&fromchange=ffe6e944fe6cb2605abc2a7e82d07bd22a5eaac7&searchStr=linux%2C18.04%2Cx64%2Cdebug%2Cmochitests%2Ctest-linux1804-64%2Fdebug-mochitest-devtools-chrome-e10s%2Cdt3&tochange=465ee033cea59e97ecdd6d9cec5f1ec26f0563c2

Failure log: https://treeherder.mozilla.org/logviewer?job_id=330552782&repo=autoland&lineNumber=19480

Backout: https://hg.mozilla.org/integration/autoland/rev/7bd409e26c42ad87c90a0e950b0e4b10b03d1d9c

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4bbe4ca120c5
Make the non-native theme not return minimum sizes for checkboxes (and most other widgets). r=spohl,mstange

Comment 10

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/4bbe4ca120c5