1693690 - nostretch.xhtml reftest fails on macOS with non-native theme enabled

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Stephen A Pohl [:spohl]]

+++ This bug was initially created as a clone of Bug #1693688 +++

Emilio, similar to bug 1693688 I'm a bit stumped with this one.

Reftest analyzer

We seem to have regressed the issue of stretching widgets described in the test, but I haven't been able to make much progress because the test also doesn't seem to work for me locally. If you can't spot anything obvious I'll try again to get this test to run for me locally. Thank you!

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1693690 - Enable the native theme in toolkit/themes/osx. r=mstange,spohl

These tests rely on implementation details of nsNativeThemeCocoa.mm

Comment 2

[Emilio Cobos Álvarez (:emilio)]

So for reference you can debug these with something like this:

diff --git a/toolkit/content/jar.mn b/toolkit/content/jar.mn
--- a/toolkit/content/jar.mn
+++ b/toolkit/content/jar.mn
@@ -1,16 +1,20 @@
 toolkit.jar:
 %  content global %content/global/ contentaccessible=yes
 *  content/global/license.html
    content/global/minimal-xul.css
 *  content/global/xul.css
    content/global/autocomplete.css
    content/global/aboutAbout.js
    content/global/aboutAbout.html
+   content/global/radiosize.xhtml (../themes/osx/reftests/radiosize.xhtml)
+   content/global/checkboxsize.xhtml (../themes/osx/reftests/checkboxsize.xhtml)
+   content/global/radiosize-ref.xhtml (../themes/osx/reftests/radiosize-ref.xhtml)
+   content/global/checkboxsize-ref.xhtml (../themes/osx/reftests/checkboxsize-ref.xhtml)
 #ifdef MOZILLA_OFFICIAL
    content/global/aboutRights.xhtml
 #else
    content/global/aboutRights.xhtml           (aboutRights-unbranded.xhtml)
 #endif
    content/global/aboutNetworking.js
    content/global/aboutNetworking.html
 #ifndef ANDROID

Then you can go to e.g. chrome://global/content/checkboxsize.xhtml.

I took a look and I'm having a hard time following these tests, but these are about the XUL toolkit code which should keep using the native theme for now anyhow so I'm not very concerned. For checkbox / radio tests there was actually an issue / interop issue between OSX and other platforms, which I fixed there (though I guess I should probably move to a separate bug), but then there's the issue that OSX checkboxes don't paint subpixels (and the tests are relying on that).

So anyhow I think this is the simplest solution.

Comment 3

[Stephen A Pohl [:spohl]]

Thank you for the jar.mn debugging solution/workaround! I will use this for any other similar test failures.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ffe6e944fe6c
Enable the native theme in toolkit/themes/osx. r=spohl

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/ffe6e944fe6c