1693723 - Avoid bootstrapping when an explicit path is given for tools

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1693723 - Pass bootstrap path in one piece to bootstrap_{,search_}path.

It will make upcoming changes simpler.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1693723 - Avoid bootstrapping when an explicit path is given for tools.

This changes things such that setting e.g. NASM=/usr/bin/nasm will avoid
bootstrapping nasm even when bootstrapping is enabled.

This is not applied to CC/CXX/HOST_CC/HOST_CXX because things are more
complicated.

This also simplifies how check_prog is called for a bootstrapped tool,
and avoids the repetition of when.

CBINDGEN handling needs the pattern being applied manually because it
currently doesn't use check_prog. Once --enable-bootstrap=install
becomes the default on developer builds, it will be possible to simplify
this.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/477431415351
Pass bootstrap path in one piece to bootstrap_{,search_}path. r=firefox-build-system-reviewers,andi,mhentges
https://hg.mozilla.org/integration/autoland/rev/83dec35a74b1
Avoid bootstrapping when an explicit path is given for tools. r=firefox-build-system-reviewers,mhentges

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/477431415351
https://hg.mozilla.org/mozilla-central/rev/83dec35a74b1