Closed Bug 1693741 Opened 7 months ago Closed 7 months ago

Retry renaming of origin directories during the storage upgrade 0_0To1_0 and 1_0To2_0

Categories

(Core :: Storage: Quota Manager, defect, P2)

defect

Tracking

()

RESOLVED FIXED
87 Branch
Tracking Status
firefox87 --- fixed

People

(Reporter: janv, Assigned: janv)

Details

Attachments

(5 files)

The QM_TRY telemetry for early beta shows that we have NS_ERROR_FILE_ACCESS_DENIED failure at this line:
https://searchfox.org/mozilla-beta/rev/6a350559b66830ba3768ef5bd3a4c97832d3a1d5/dom/quota/ActorsParent.cpp#10848

It's very likely that it fails because of interference with a virus or anti-virus. We could try to do some other tricks to fix this, but I believe the safest option is to just retry the operation several times.

Attachment #9204144 - Attachment description: Bug 1693741 - Check for existing targets before renaming origins during storage upgrade from v0.0 to v1.0; r=#dom-storage → Bug 1693741 - Check for existing targets before renaming origin directories during storage upgrade from v0.0 to v1.0; r=#dom-storage
Attachment #9204145 - Attachment description: Bug 1693741 - Shared code for origin renaming during storage upgrades; r=#dom-storage → Bug 1693741 - Share code for origin renaming between storage upgrade classes; r=#dom-storage
Summary: Retry renaming of origin directories during the storage upgrade from v0.0 to v1.0 → Retry renaming of origin directories during the storage upgrade 0_0To1_0 and 1_0To2_0
Pushed by jvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/77bc3a172720
Remove redundant GetLeafName calls; r=dom-storage-reviewers,sg
https://hg.mozilla.org/integration/autoland/rev/ecc890a10c29
Handle origin renaming during storage upgrade from v0.0 to v1.0 in a dedicated method; r=dom-storage-reviewers,sg
https://hg.mozilla.org/integration/autoland/rev/767c2bd73245
Check for existing targets before renaming origin directories during storage upgrade from v0.0 to v1.0; r=dom-storage-reviewers,sg
https://hg.mozilla.org/integration/autoland/rev/5badb148963f
Share code for origin renaming between storage upgrade classes; r=dom-storage-reviewers,sg
https://hg.mozilla.org/integration/autoland/rev/dcc12ac96da9
Retry removing or renaming of origin directories in StorageOperationBase::MaybeRenameOrigin; r=dom-storage-reviewers,sg
You need to log in before you can comment on or make changes to this bug.