1693741 - Retry renaming of origin directories during the storage upgrade 0_0To1_0 and 1_0To2_0

Status: RESOLVED FIXED

(Core :: Storage: Quota Manager, defect, P2)

Description

[Jan Varga [:janv]]

The QM_TRY telemetry for early beta shows that we have NS_ERROR_FILE_ACCESS_DENIED failure at this line:
https://searchfox.org/mozilla-beta/rev/6a350559b66830ba3768ef5bd3a4c97832d3a1d5/dom/quota/ActorsParent.cpp#10848

It's very likely that it fails because of interference with a virus or anti-virus. We could try to do some other tricks to fix this, but I believe the safest option is to just retry the operation several times.

Comment 1

[Jan Varga [:janv]]

Attachment: Bug 1693741 - Remove redundant GetLeafName calls; r=#dom-storage

Comment 2

[Jan Varga [:janv]]

Attachment: Bug 1693741 - Handle origin renaming during storage upgrade from v0.0 to v1.0 in a dedicated method; r=#dom-storage

Depends on D105728

Comment 3

[Jan Varga [:janv]]

Attachment: Bug 1693741 - Check for existing targets before renaming origin directories during storage upgrade from v0.0 to v1.0; r=#dom-storage

Depends on D105729

Comment 4

[Jan Varga [:janv]]

Attachment: Bug 1693741 - Share code for origin renaming between storage upgrade classes; r=#dom-storage

Depends on D105730

Comment 5

[Jan Varga [:janv]]

Attachment: Bug 1693741 - Retry removing or renaming of origin directories in StorageOperationBase::MaybeRenameOrigin; r=#dom-storage

Depends on D105732

Comment 6

[Jan Varga [:janv]]

https://treeherder.mozilla.org/jobs?repo=try&revision=fa0ced4ab1beb2d26b3944ed81bcedcb4446726c

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/77bc3a172720
Remove redundant GetLeafName calls; r=dom-storage-reviewers,sg
https://hg.mozilla.org/integration/autoland/rev/ecc890a10c29
Handle origin renaming during storage upgrade from v0.0 to v1.0 in a dedicated method; r=dom-storage-reviewers,sg
https://hg.mozilla.org/integration/autoland/rev/767c2bd73245
Check for existing targets before renaming origin directories during storage upgrade from v0.0 to v1.0; r=dom-storage-reviewers,sg
https://hg.mozilla.org/integration/autoland/rev/5badb148963f
Share code for origin renaming between storage upgrade classes; r=dom-storage-reviewers,sg
https://hg.mozilla.org/integration/autoland/rev/dcc12ac96da9
Retry removing or renaming of origin directories in StorageOperationBase::MaybeRenameOrigin; r=dom-storage-reviewers,sg

Comment 8

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/77bc3a172720
https://hg.mozilla.org/mozilla-central/rev/ecc890a10c29
https://hg.mozilla.org/mozilla-central/rev/767c2bd73245
https://hg.mozilla.org/mozilla-central/rev/5badb148963f
https://hg.mozilla.org/mozilla-central/rev/dcc12ac96da9