1693851 - Investigate and fix tests that fail when the Proton AppMenu is enabled by default

Status: RESOLVED FIXED

(Firefox :: Menus, task, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

As it says on the tin. We don't want to get surprised by an orange tree when we turn this thing on.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Try build cooking here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=297f6368971856e903b5c6f3515fca3c61d04154

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Here's a list of mochitest-browser tests that need investigating(*):

• browser/base/content/test/protectionsUI/browser_protectionsUI.js
• browser/base/content/test/protectionsUI/browser_protectionsUI_animation_2.js (failed due to previous failure)
• toolkit/components/pictureinpicture/tests/browser_videoSelection.js (intermittent)
• browser/components/uitour/test/browser_UITour2.js
• browser/components/uitour/test/browser_UITour4.js
• browser/components/uitour/test/browser_UITour5.js
• browser/components/uitour/test/browser_UITour_availableTargets.js
• browser/components/uitour/test/browser_fxa.js
• browser/components/newtab/test/browser/browser_asrouter_whatsnewpanel.js
• browser/components/places/tests/browser/browser_panelview_bookmarks_delete.js
• browser/components/places/tests/browser/browser_stayopenmenu.js
• toolkit/components/passwordmgr/test/browser/browser_entry_point_telemetry.js
• toolkit/components/printing/tests/browser_window_print.js
• browser/base/content/test/sync/browser_sync.js
• browser/modules/test/browser/browser_UsageTelemetry_interaction.js
• browser/components/customizableui/test/browser_ctrl_click_panel_opening.js
• browser/components/customizableui/test/browser_library_after_appMenu.js
• browser/components/customizableui/test/browser_panel_keyboard_navigation.js
• browser/components/tests/browser/browser_quit_disabled.js

These should be re-checked after the Firefox Accounts panel bug (bug 1690131) is closed.

(*): Some of these might be intermittent test failures.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

The UITour issues should be addressed by bug 1694197 and bug 1694195.

Comment 4

[Blake Winton (:bwinton) (:☕️)]

As per guidance from Vicky, for tracking, we're marking all the bugs that people are working on as P1.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1693851 - Fix browser_sync.js tests when Proton AppMenu is enabled. r?markh!

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1693851 - Fix some variety of tests so that they pass with and without Proton AppMenu enabled. r?emalysz!

Depends on D106380

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4937e561af74
Fix browser_sync.js tests when Proton AppMenu is enabled. r=markh
https://hg.mozilla.org/integration/autoland/rev/0ea3ac7c18b9
Fix some variety of tests so that they pass with and without Proton AppMenu enabled. r=emalysz

Comment 9

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/4937e561af74
https://hg.mozilla.org/mozilla-central/rev/0ea3ac7c18b9